Bug 1256335

The package-name-white-list was added for https://bugzilla.redhat.com/show_bug.cgi?id=1155371 to limit the classes analysed. Simply defaulting to an empty file would only lead to this referenced BZ being re-opened. There needs to be a more intelligent solution. 

For example, when authoring classes using the Data Object Modeller we could add "new" packages automatically to the package-name-white-list. We could also provide the user with a "pick list" of packages contained in dependencies when added to the Project that would be appended to the package-name-white-list (i.e. "Please select the packages containing classes required for authoring..." type selector).

It would be good for you to liaise with Justin Holmes (reporter of the referenced BZ, jholmes) to agree a more complete and generally acceptable solution.

(In reply to manstis from comment #1)
> The package-name-white-list was added for
> https://bugzilla.redhat.com/show_bug.cgi?id=1155371 to limit the classes
> analysed. Simply defaulting to an empty file would only lead to this
> referenced BZ being re-opened. There needs to be a more intelligent
> solution. 
> 
> For example, when authoring classes using the Data Object Modeller we could
> add "new" packages automatically to the package-name-white-list. We could
> also provide the user with a "pick list" of packages contained in
> dependencies when added to the Project that would be appended to the
> package-name-white-list (i.e. "Please select the packages containing classes
> required for authoring..." type selector).
> 
> It would be good for you to liaise with Justin Holmes (reporter of the
> referenced BZ, jholmes) to agree a more complete and generally
> acceptable solution.

That sounds very interesting actually. I think it would make working with package-name-white-list and data objects much more pleasant. I'll get in touch with Justin Holmes.

Thanks for the reminder - I totally overlooked that default as being a part of that BZ. I think that the reason I haven't hit the same thing sooner is that earlier, when creating new project, the current package was set to be the deepest level created by default. Now it dropped me into the default (top most) package.. caught me by surprise. :-D

Mich(In reply to manstis from comment #1)

> For example, when authoring classes using the Data Object Modeller we could
> add "new" packages automatically to the package-name-white-list. We could
> also provide the user with a "pick list" of packages contained in
> dependencies when added to the Project that would be appended to the
> package-name-white-list (i.e. "Please select the packages containing classes
> required for authoring..." type selector).

This is a solid approach, although I'm not sure what the workflow for such a prompt would be. 

In general, the goal of this feature is to help preserve performance when the KieModule's pom.xml is polluted with dependencies that are not needed for modeling (but perhaps for execution or testing). I don't want to prescribe an implementation, so let's take a behavior driven approach. IMHO there are two key scenarios here:


Given a KieModule loaded in Business Central
When loading the data model for guided editing takes less than 2 seconds
Then I should be able to see new data objects available as facts in the guided editor  

Given a KieModule loaded in Business Central
When loading the data model for guided editing takes more than 2 seconds
Then I should receive an alert that the data model has become polluted
And an administrator should be contacted with guidance on how to restrict the packages used in the data model


Let me know if you want to talk through these scenarios in more detail

https://issues.jboss.org/browse/GUVNOR-2273

The latest changes change the package white list to white list all the models in the current project by default. Listing them in the white list file is no longer needed. Any packages from the dependencies still need to be white listed.