Bug 1256400

Summary: Incorrect behaviour in Assignments property for variable with whitespaces
Product: [Retired] JBoss BRMS Platform 6 Reporter: Kirill Gaevskii <kgaevski>
Component: Business CentralAssignee: manstis
Status: CLOSED EOL QA Contact: Jozef Marko <jomarko>
Severity: medium Docs Contact:
Priority: high    
Version: 6.2.0CC: jomarko, kverlaen, lpetrovi
Target Milestone: ER5   
Target Release: 6.2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-03-27 19:36:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Kirill Gaevskii 2015-08-24 13:25:55 UTC
Description of problem:
If you will add variable name with whitespaces in new DataMapper editor it will be shown in Assignments property like normal variable: "[din]Some variable=Some value". But after saving and reopening process it will be "[din]=Some value" and if you will open the DataMapper editor there will be no [incorrect] variables to show. Correct variables will be present.

Version-Release number of selected component (if applicable):
6.2.ER1

How reproducible:
always

Steps to Reproduce:
1. Create Business Process with Manual Task
2. Add Input Variable throw Assignments (DataMapper) Editor: [Name="Some name", type="String", Source="Some value"]
3. Click "Save" button
4. Assignments field will contain string "[din]Some variable=Some value"
5. Save Business Process
6. Reopen Business Process
7. Assignments field will contain string "[din]=Some Value"
8. Open Assignments (DataMapper) Editor. No variables will presented at all.

Actual results:
Point 4. contain mapping for variable with wrong variable name
Point 7. Assignments field have no actual name of variable at all
Point 8. Before you open an Assignments (DataMapper) Editor you saw some data in Assignments but in editor you see nothing.

Expected results:
On Point 3. or even Point 2. user will see text message (Something like "incorrect name of variable") or another understandable warning about wrong action.
Point 4. and Point 7. No incorrect data in Assignments field.

Additional info:
https://docs.google.com/document/d/1hq_veY_eBLiweKb0TWdjP27RQKuWGaubUHl4TJoMR04
https://issues.jboss.org/browse/BPMSPL-127

P.S. If you will try to type wrong variable name in other ways (for example variable#2). You can see it like in this issue (Point 4.), but after saving you can't to open this Business Process in normal way (You will see XML editor for Business Process instead). May be it is another issue.

Comment 2 Kris Verlaenen 2015-09-08 07:43:49 UTC
Note that we should not accept variable names with spaces or special characters.

Comment 3 Jeremy Lindop 2015-09-11 16:09:30 UTC
Fixed by preventing typing space character in name field.

master: https://github.com/droolsjbpm/jbpm-designer/commit/b40c8896323dac22a4ddc069b8180091fffc9d69
6.3.x: https://github.com/droolsjbpm/jbpm-designer/commit/03058b8c95faddd608093568747c414050ed3564

For the note at the end about other illegal chars in names, I created:
https://bugzilla.redhat.com/show_bug.cgi?id=1262432

Comment 4 Kirill Gaevskii 2015-09-22 15:28:07 UTC
It is not possible to TYPE whitespace any more, but if you will COPY and PASTE some text with whitespace (for example: "Employee name") you will encounter the same behaviour.

Comment 6 Jozef Marko 2015-11-03 14:16:06 UTC
Impossible to type white spaces or other special characters like #,@,%,$ as name for data assignment.

Verified on 6.2.0.ER5