Bug 1256479

The spec url is wrong, it should be: https://gitlab.com/mcepl/gedit-plugin-git-pkg/raw/epel7/gedit-plugin-git.spec (raw instead of blob).

And SRPM is now http://mcepl.fedorapeople.org/tmp/gedit-plugin-git-3.14.1-4.el7.src.rpm

First findings:

> %description
> The gedit git plugin packages separately (because it requires
> packages not available in the RHEL-7 proper but only in EPEL-7)

The description doesn't tell anything useful about what the package does…


> %patch1 -p1 -b .FSF-addr

Patching copyright headers is discouraged.  See: https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address


The URLs you've pasted are not suitable for fedora-review, btw…  Spec resolves to some HTML-page.  They should look like:

Spec URL: https://gitlab.com/mcepl/gedit-plugin-git-pkg/raw/epel7/gedit-plugin-git.spec
SRPM URL: https://mcepl.fedorapeople.org/tmp/gedit-plugin-git-3.14.1-4.el7.src.rpm


I'm somehow wondering:  Is this package intended for el7, only?  Do we have this plugin in Fedora already?

(In reply to Björn "besser82" Esser from comment #3)
> First findings:
> 
> > %description
> > The gedit git plugin packages separately (because it requires
> > packages not available in the RHEL-7 proper but only in EPEL-7)
> 
> The description doesn't tell anything useful about what the package does…

That’s right. It is just a copy from the subpackage of gedit-plugins. I'll try to do something better. As for the second sentence, see below.

See new src.rpm at http://mcepl.fedorapeople.org/tmp/gedit-plugin-git-3.14.1-5.el7.src.rpm (SPEC is also updated)

> > %patch1 -p1 -b .FSF-addr
> 
> Patching copyright headers is discouraged.  See:
> https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address

Of course, the patch is upstream as well. https://git.gnome.org/browse/gedit-plugins/commit/?id=382a196b177f87c0c1d356a7fa18ec3cefb43d25

> I'm somehow wondering:  Is this package intended for el7, only?  Do we have
> this plugin in Fedora already?

Sorry to be snippy, but if you read that %description which tell you nothing useful you may understand the situation. ;)

Yes, this is EPEL7 only, and yes it is a part of gedit-plugins in Fedora, but because it depends on libgit2 which is not in RHEL-7 it has been patched out in RHEL-7 gedit-plugins package.

When trying to run it in fedora-review for epel-7 I get the following error:

error: syntax error in expression
error: /home/jens/1256479-gedit-plugin-git/srpm/gedit-plugin-git.spec:1: bad %if condition

running in mock directly leads to:
Error: No Package found for libgit2-glib-devel
Error: No Package found for vte291-devel

Obviously BR needs to be fixed.

I s there no way to make it a sub-package for epel-7 (from same spec-file), with some (many?) conditionals depending on the %{dist} ?

(In reply to Jens Lody from comment #5)
> Obviously BR needs to be fixed.

It is blocked by bug 1256475 (and yes, that one will be also resolvable only sometime).

> I s there no way to make it a sub-package for epel-7 (from same spec-file),
> with some (many?) conditionals depending on the %{dist} ?

there is no gedit-plugins package for EPEL-7.

This is an automatic action taken by review-stats script.

The submitter account doesn't exist anymore, therefore this ticket will be closed.