Bug 1256669

Summary:	Though scrubber settings changed on one volume log shows all volumes scrubber information
Product:	[Community] GlusterFS	Reporter:	Kotresh HR <khiremat>
Component:	bitrot	Assignee:	Kotresh HR <khiremat>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:	bugs <bugs>
Priority:	unspecified
Version:	3.7.0	CC:	annair, asrivast, bugs, nsathyan, rmekala, vshankar
Target Milestone:	---	Keywords:	ZStream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.4	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1252825	Environment:
Last Closed:	2015-09-09 09:40:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1238634, 1252825
Bug Blocks:

Description Kotresh HR 2015-08-25 08:43:43 UTC

+++ This bug was initially created as a clone of Bug #1252825 +++

+++ This bug was initially created as a clone of Bug #1238634 +++

Description of problem:
===================
Though scrubber settings changed on one volume, we are showing all scrubber settings information

Version-Release number of selected component (if applicable):
=================


How reproducible:
=====================



Steps to Reproduce:
==============
1.Create a few volumes and enable bitrot 
2.Change scrub frequency from default to hourly on one of the volume and check the scrubber log
3.

Actual results:
===============
Log shows all volume scrubber information and it is confusing 

Expected results:
=============
It would be good to show only affected volume settings

Comment 1 Anand Avati 2015-08-25 08:45:04 UTC

REVIEW: http://review.gluster.org/12010 (features/bitrot: Fix scrubber frequency set) posted (#1) for review on release-3.7 by Kotresh HR (khiremat)

Comment 2 Anand Avati 2015-08-26 09:06:32 UTC

REVIEW: http://review.gluster.org/12010 (features/bitrot: Fix scrubber frequency set) posted (#2) for review on release-3.7 by Raghavendra Talur (rtalur)

Comment 3 Anand Avati 2015-08-27 09:18:42 UTC

COMMIT: http://review.gluster.org/12010 committed in release-3.7 by Venky Shankar (vshankar) 
------
commit 3b63a2eb7f9a67360564cf949de6e7a0e7313153
Author: Kotresh HR <khiremat>
Date:   Wed Aug 12 15:25:03 2015 +0530

    features/bitrot: Fix scrubber frequency set
    
    When bitrot is configured on multiple volumes
    in a cluster and scrubber-frequency is changed
    for one volume, it is resetting frequency for
    all other volumes w.r.t to its scrubber-frequency.
    This should not happen. Changing scrubber-frequency
    should affect only that volume on which it is set.
    This patch fixes the issue.
    
    Also restricted the logs to the configure volume.
    
    BUG: 1256669
    Change-Id: I6eba385b50b3bdc86bc8f4ef295a004b3b87b68a
    Reviewed-on: http://review.gluster.org/11897
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra Bhat <raghavendra>
    Reviewed-by: Venky Shankar <vshankar>
    Signed-off-by: Kotresh HR <khiremat>
    Reviewed-on: http://review.gluster.org/12010

Comment 4 Kaushal 2015-09-09 09:40:43 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.4, please open a new bug report.

glusterfs-3.7.4 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12496
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user