Bug 1256941

Summary: UI : Error: Wrong validation message shown when template not selected for SCVMM provider
Product: Red Hat CloudForms Management Engine Reporter: Shveta <sshveta>
Component: UI - OPSAssignee: Aparna Karve <akarve>
Status: CLOSED ERRATA QA Contact: Dave Johnson <dajohnso>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.4.0CC: cpelland, hkataria, jhardy, jprause, mfeifer, mpovolny, obarenbo
Target Milestone: GAKeywords: ZStream
Target Release: 5.4.5   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.4.5.2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-03-29 14:14:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
err none

Description Shveta 2015-08-25 19:43:54 UTC
Created attachment 1066972 [details]
err

Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Create a catalog item for SCVMM provider (Note : provider is not added )
2. Fill all fields except template and save
3. Messages shown says " catalog name is required " 

Message should be "Source_id must have valid template" Like it is shown for Vmware and RHEV provider

Actual results:


Expected results:


Additional info:
5.4.2.0.20150820153254_83e434d

Comment 2 CFME Bot 2016-01-15 22:57:16 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=dab4ca6f40070aa8598d25a486693670684d32be

commit dab4ca6f40070aa8598d25a486693670684d32be
Author:     Aparna Karve <akarve>
AuthorDate: Thu Jan 14 16:45:13 2016 -0800
Commit:     Aparna Karve <akarve>
CommitDate: Fri Jan 15 11:24:00 2016 -0800

    Perform validation for the entire 'Add Catalog item' form.
    Fixed the validate method (now matches upstream code)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1256941

 vmdb/app/models/miq_request_workflow.rb | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comment 3 CFME Bot 2016-01-15 22:57:21 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=a20aee00eb8d2206a2a904ca37207c279d4ba9ba

commit a20aee00eb8d2206a2a904ca37207c279d4ba9ba
Merge: a270081 dab4ca6
Author:     Dan Clarizio <dclarizi>
AuthorDate: Fri Jan 15 17:56:10 2016 -0500
Commit:     Dan Clarizio <dclarizi>
CommitDate: Fri Jan 15 17:56:10 2016 -0500

    Merge branch 'bz1256941_fix_validation_messages' into '5.4.z'
    
    BZ1256941 - Fixed the validate method such that it performs validation for all fields in 'Add Catalog item' form.
    
    Fixed the ```validate``` method in 5.4.z to match the ```validate``` method in upstream
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1256941
    
    Changes were applied manually.
    
    See merge request !721

 vmdb/app/models/miq_request_workflow.rb | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comment 4 Aparna Karve 2016-01-15 22:58:58 UTC
Shveta, with the above fix you should see consistency in the validation messages across all providers.

Comment 6 Shveta 2016-02-02 21:05:13 UTC
Verified in 5.4 5.4.5.0.20160120124945_d8bf7e3

Comment 8 errata-xmlrpc 2016-03-29 14:14:25 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-0171.html