Bug 1257178

Hi Marcos, I'll be sponsoring you.
Please do two informal reviews and link them back here (you can take two from the RDO LIBERTY REVIEWS tracker)

Quick review:
* Group tags are not required anymore
* use python versioned macros
* packaging guidelines have recently changed:
https://fedoraproject.org/wiki/Packaging:Python#Guidelines
=> ensure that python2-yaql provides python-yaql
* python3 subpackage is now mandatory
* noarch package, so the CFLAGS are not needed

Thank you for your sponsorship Haïkel Guémar and for your quick review, I'll fix it following your comments.

This is my first informal review: https://bugzilla.redhat.com/show_bug.cgi?id=1252784#c1

I'll back soon with the second one.

Here is my second informal review https://bugzilla.redhat.com/show_bug.cgi?id=1259919

I'll back with the changes that you pointed about my package

Hi Haïkel,

I'm back with the changes

SPEC URL: http://mferminl.web.cern.ch/mferminl/fedorapkg/python-yaql/python-yaql.spec
SRPM URL: http://mferminl.web.cern.ch/mferminl/fedorapkg/python-yaql/python-yaql-0.2.7-1.fc23.src.rpm

I think I addressed all your comments.

Thank you for your review.

Hi Haitkel,

Do I need to make more changes?. Please, let me know if any change is necessary or if I should review more packages. After this package, I will able to send openstack-murano package (python-yaql is a dependency).

Thank you for your time.

Missing definition of with_python3, so it fails to build.
Please drop max version in requirements,

%python_siteXXX definitions are not needed and should be dropped too.
Needinfo me when it's done.

Hi Haikel,

I've achieved your comments. Please, check again here:

SPEC URL: http://mferminl.web.cern.ch/mferminl/fedorapkg/python-yaql/python-yaql.spec
SRPM URL: http://mferminl.web.cern.ch/mferminl/fedorapkg/python-yaql/python-yaql-0.2.7-1.fc23.src.rpm

Thank you for your review.

hguemar's scratch build of python-yaql-0.2.7-1.fc23.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11385645

mflobo's scratch build of python-yaql-0.2.7-1.fc23.src.rpm for f23-candidate failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11386482

mflobo's scratch build of python-yaql-0.2.7-1.fc23.src.rpm for f23-candidate failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11425270

Hi Haikel,

I'm trying to figure out what is happening with the scratch buildings but as far I understand, the problem is related with Python 3.4 and PBR library https://kojipkgs.fedoraproject.org//work/tasks/5271/11425271/build.log, so not related with my RPM...

I don't understand how can I fix this. Could you have any clue for me?

Thank you.

mflobo's scratch build of python-yaql-0.2.7-1.fc23.src.rpm for f23-candidate completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11428044

Hi Haikel,

I've added the missed for python3. Please, check again here:

SPEC URL: http://mferminl.web.cern.ch/mferminl/fedorapkg/python-yaql/python-yaql.spec
SRPM URL: http://mferminl.web.cern.ch/mferminl/fedorapkg/python-yaql/python-yaql-0.2.7-1.fc23.src.rpm

As you can see, there is a successful scratch build for f23-candidate

Thank you for your review.

Hi Marcos, I now sponsored into the Fedora Packagers Group, so feel free to reach me out as your sponsor whenever you need help.

I hereby approve this package into Fedora Packages Collection, please submit a request in PKGDB to create the new component.



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Unknown or generated". 2 files have unknown
     license. Detailed output of licensecheck in /home/haikel/1257178
     -python-yaql/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python2-yaql , python3-yaql , python-yaql-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python2-yaql-0.2.7-1.fc24.noarch.rpm
          python3-yaql-0.2.7-1.fc24.noarch.rpm
          python-yaql-doc-0.2.7-1.fc24.noarch.rpm
          python-yaql-0.2.7-1.fc24.src.rpm
python2-yaql.noarch: W: summary-ended-with-dot C YAQL library has a out of the box large set of commonly used functions.
python2-yaql.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/yaql/cli/run.py 644 /usr/bin/env
python2-yaql.noarch: W: dangling-relative-symlink /usr/bin/yaql-3 python3-yaql
python2-yaql.noarch: W: dangling-relative-symlink /usr/bin/yaql-3.4 python3-yaql
python2-yaql.noarch: W: no-manual-page-for-binary yaql-3.4
python2-yaql.noarch: W: no-manual-page-for-binary yaql-2.7
python2-yaql.noarch: W: no-manual-page-for-binary yaql-3
python2-yaql.noarch: W: no-manual-page-for-binary yaql-2
python2-yaql.noarch: W: no-manual-page-for-binary yaql
python3-yaql.noarch: W: summary-ended-with-dot C YAQL library has a out of the box large set of commonly used functions.
python3-yaql.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/yaql/cli/run.py 644 /usr/bin/env
python3-yaql.noarch: W: no-manual-page-for-binary python3-yaql
python3-yaql.noarch: W: no-manual-page-for-binary yaql-3
python3-yaql.noarch: W: no-manual-page-for-binary yaql-3.4
python3-yaql.noarch: W: no-manual-page-for-binary yaql
python3-yaql.noarch: W: no-manual-page-for-binary yaql-2
python3-yaql.noarch: W: no-manual-page-for-binary yaql-2.7
4 packages and 0 specfiles checked; 2 errors, 15 warnings.




Rpmlint (installed packages)
----------------------------
python2-yaql.noarch: W: summary-ended-with-dot C YAQL library has a out of the box large set of commonly used functions.
python2-yaql.noarch: W: dangling-relative-symlink /usr/bin/yaql-3 python3-yaql
python2-yaql.noarch: W: dangling-relative-symlink /usr/bin/yaql-3.4 python3-yaql
python2-yaql.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/yaql/cli/run.py 644 /usr/bin/env
python2-yaql.noarch: W: no-manual-page-for-binary yaql-2
python2-yaql.noarch: W: no-manual-page-for-binary yaql-3
python2-yaql.noarch: W: no-manual-page-for-binary yaql-3.4
python2-yaql.noarch: W: no-manual-page-for-binary yaql
python2-yaql.noarch: W: no-manual-page-for-binary yaql-2.7
python3-yaql.noarch: W: summary-ended-with-dot C YAQL library has a out of the box large set of commonly used functions.
python3-yaql.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/yaql/cli/run.py 644 /usr/bin/env
python3-yaql.noarch: W: no-manual-page-for-binary python3-yaql
python3-yaql.noarch: W: no-manual-page-for-binary yaql-3
python3-yaql.noarch: W: no-manual-page-for-binary yaql
python3-yaql.noarch: W: no-manual-page-for-binary yaql-2
python3-yaql.noarch: W: no-manual-page-for-binary yaql-3.4
python3-yaql.noarch: W: no-manual-page-for-binary yaql-2.7
3 packages and 0 specfiles checked; 2 errors, 15 warnings.



Requires
--------
python2-yaql (rpmlib, GLIBC filtered):
    /usr/bin/python2
    python(abi)

python-yaql-doc (rpmlib, GLIBC filtered):

python3-yaql (rpmlib, GLIBC filtered):
    /usr/bin/python2
    /usr/bin/python3
    python(abi)
    python3-babel
    python3-pbr
    python3-ply
    python3-six



Provides
--------
python2-yaql:
    python-yaql
    python2-yaql

python-yaql-doc:
    python-yaql-doc

python3-yaql:
    python3-yaql



Source checksums
----------------
http://pypi.python.org/packages/source/y/yaql/yaql-0.2.7.tar.gz :
  CHECKSUM(SHA256) this package     : 06d91bd79ec324e7b6998256920a5b61f8946d729d5f999b5119b03e84ac1ed2
  CHECKSUM(SHA256) upstream package : 06d91bd79ec324e7b6998256920a5b61f8946d729d5f999b5119b03e84ac1ed2


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1257178 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Package has been created in pkgdb
https://admin.fedoraproject.org/pkgdb/package/python-yaql/
but there are no builds yet
http://koji.fedoraproject.org/koji/packageinfo?packageID=21190
?

Sorry, my bad. Now there is the build. 

Question: This package is new, I mean, is not an update, so is mandatory to put it in Bodhi?

Please, let me know if more actions are required.

Marcos: yes, you have to import it in dist-git, build it and submit an update through bodhi (or use fedpkg update).

$ fedpkg update

############## bodhi template
[ python-yaql-0.2.7-1.fc24 ]

# bugfix, security, enhancement, newpackage (required)
type=newpackage

# testing, stable
request=testing

# Bug numbers: 1234,9876
bugs=1257178


# Here is where you give an explanation of your update.
notes=First RPM for FC23

# Enable request automation based on the stable/unstable karma thresholds
autokarma=True
stable_karma=3
unstable_karma=-3

# Automatically close bugs when this marked as stable
close_bugs=True

# Suggest that users restart after update
suggest_reboot=False

It raises this bodhi error:

fedora.client.bodhi.BodhiClientException: Invalid tag: python-yaql-0.2.7-1.fc24 tagged with [u'epel7-testing-candidate', u'dist-6E-epel-testing-candidate', u'dist-5E-epel-testing-candidate', u'f22-updates-candidate', u'f21-updates-candidate', u'f23-updates-candidate']
Unable to determine release from build: python-yaql-0.2.7-1.fc24

I don't know how to set te correct tag for this build.

Thanks in advance.

No Bodhi updates are needed for f24/Rawhide
you need them to push to the f23, f22 or epel7 i.e. current releases.

BTW please update to the latest release!
1.0.0 was release on Aug 20 and 1.0.2 on Sep 16 so it should've been included in the review already i.e. this was not correct!
[x]: Latest version is packaged.

$ fedpkg switch-branch epel7
Switched to branch 'epel7'
$ git merge master
... OK
$ git push
Total 0 (delta 0), reused 0 (delta 0)
remote: Emitting a message to the fedmsg bus.
remote: * Publishing information for 1 commits
To ssh://mflobo.org/python-yaql
   fcb303f..2207ae7  epel7 -> epel7
$ fedpkg build
FAILED http://koji.fedoraproject.org/koji/taskinfo?taskID=11891084 

The build.log:

...
writing manifest file 'yaql.egg-info/SOURCES.txt'
+ sphinx-build doc/source html
Making output directory...
Running Sphinx v1.1.3
Extension error:
Could not import extension oslosphinx (exception: No module named oslosphinx)
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.4Yx7eC (%build)
    Bad exit status from /var/tmp/rpm-tmp.4Yx7eC (%build)
Child return code was: 1
EXCEPTION: Command failed. See logs for output.


I tried:
$ fedpkg switch-branch f23
Could not execute switch_branch: Unknown remote branch origin/f23

And other fedora versions like f23 and I can not change the branch in order to push to other branch

ok, so epel7 is no go, since it requires latest OpenStack deps which do not plan to push there, we'll keep EL7 builds in RDO.

For f23, please request branch in pkgdb: https://fedoraproject.org/wiki/PackageDB_admin_requests

python-yaql-0.2.7-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-c22d266f42

Hi Alan,

The new branch f23 for python-yaql was requested, the build was successful and the package was pushed to bodhi for testing https://bodhi.fedoraproject.org/updates/FEDORA-2015-c22d266f42.

Is there any other step that I need to accomplish in order to finish with this first version of python-yaql?

Thank you.

Hi,

New version in the horizon: 1.0.2

Spec URL: http://mferminl.web.cern.ch/mferminl/fedorapkg/python-yaql/1.0.2/python-yaql.spec
SRPM URL: http://mferminl.web.cern.ch/mferminl/fedorapkg/python-yaql/1.0.2/python-yaql-1.0.2-1.fc23.src.rpm

Why push obsolete 0.2.7 version?
Re. 1.0.2 no need for re-review, just push it to distgit and build in Koji!

python-yaql-0.2.7-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update python-yaql'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-c22d266f42

python-yaql-0.2.7-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update python-yaql'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-c22d266f42

python-yaql-0.2.7-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Version 1.0.2 was already pushed http://koji.fedoraproject.org/koji/buildinfo?buildID=700045