Bug 1257280

Summary:	[DOC] virDomainDetachDevice lacks of information detailed in virDomainDetachDeviceFlags.
Product:	[Community] Virtualization Tools	Reporter:	Amit Aviram <aaviram>
Component:	libvirt	Assignee:	Libvirt Maintainers <libvirt-maint>
Status:	CLOSED NEXTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	amureini, jdenemar, rbalakri
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-11-26 09:59:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Amit Aviram 2015-08-26 16:06:35 UTC

Description of problem:
at virDomainDetachDeviceFlags Doc, it is stated that this function is asynchronous, and the user should verify that a device was actually detached after using it.

at virDomainDetachDevice Doc, Nothing is mentioned regarding that issue, which is misleading.

Expected results:
All the information regarding how virDomainDetachDevice works, and what differs it from virDomainDetachDeviceFlags should be detailed in the Docs.

Comment 1 Jiri Denemark 2015-11-26 09:59:41 UTC

This is now fixed upstream by v1.2.21-141-g63fd27c

commit 63fd27cfa35f39b32692b9c66e59c4d157ce8806
Author: Jiri Denemark <jdenemar>
Date:   Wed Nov 25 16:39:17 2015 +0100

    Enhance documentation of virDomainDetachDevice
    
    Link it to virDomainDetachDeviceFlags.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1257280
    
    Signed-off-by: Jiri Denemark <jdenemar>