Bug 1257875

Summary:	tor: Logging malformed hostnames in socks5 requests leaks sensitive information
Product:	[Other] Security Response	Reporter:	Adam Mariš <amaris>
Component:	vulnerability	Assignee:	Red Hat Product Security <security-response-team>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	low	Docs Contact:
Priority:	low
Version:	unspecified	CC:	lmacken, pwouters, s
Target Milestone:	---	Keywords:	Security
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-01-10 18:06:30 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1257877, 1257878
Bug Blocks:

Description Adam Mariš 2015-08-28 10:02:30 UTC

A bug was found in src/or/buffers.c::parse_socks(), where escaped() function on the request address is used rather than escaped_safe_str_client(). When a socks5 client application sends a request with a malformed hostname, the full hostaname is logged, while rejecting the connection, instead of logging [scrubbed] name, respecting the SafeLogging configuration.

Upstream patch:

https://gitweb.torproject.org/tor.git/commit/?id=19df037e53331ae528b876f225be08f198e0f8b6

Comment 1 Adam Mariš 2015-08-28 10:03:23 UTC

Created tor tracking bugs for this issue:

Affects: fedora-all [bug 1257877]
Affects: epel-all [bug 1257878]