Bug 1257881

Summary:	Quota list on a volume hangs after glusterd restart an a node.
Product:	[Community] GlusterFS	Reporter:	Vijaikumar Mallikarjuna <vmallika>
Component:	cli	Assignee:	Vijaikumar Mallikarjuna <vmallika>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	3.7.3	CC:	bugs, ggarg, gluster-bugs, smohan, storage-qa-internal, trao
Target Milestone:	---	Keywords:	Regression
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.7.4	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1242819	Environment:
Last Closed:	2015-09-09 09:41:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1242803, 1242819
Bug Blocks:

Comment 1 Anand Avati 2015-08-28 10:09:50 UTC

REVIEW: http://review.gluster.org/12038 (cli: on error invoke cli_cmd_broadcast_response function in separate thread) posted (#1) for review on release-3.7 by Vijaikumar Mallikarjuna (vmallika)

Comment 2 Anand Avati 2015-08-31 06:37:02 UTC

REVIEW: http://review.gluster.org/12038 (cli: on error invoke cli_cmd_broadcast_response function in separate thread) posted (#2) for review on release-3.7 by Vijay Bellur (vbellur)

Comment 3 Anand Avati 2015-08-31 15:04:31 UTC

COMMIT: http://review.gluster.org/12038 committed in release-3.7 by Kaushal M (kaushal) 
------
commit d90ed0b9b7160911c3fb8515f2947579d0fd197f
Author: vmallika <vmallika>
Date:   Mon Aug 24 08:07:14 2015 +0530

    cli: on error invoke cli_cmd_broadcast_response function in separate thread
    
    This is a backport of http://review.gluster.org/#/c/11990/
    
    There is a problem in current CLI framework
    CLI holds the lock when processing command.
    When processing quota list command, below sequence of steps executed in the
    same thread and causing deadlock
    
    1) CLI holds the lock
    2) Send rpc_clnt_submit request to quotad for quota usage
    3) If quotad is down, rpc_clnt_submit invokes cbk function with error
    4) cbk function cli_quotad_getlimit_cbk tries to hold lock to broadcast
       the results and hangs, because same thread has already holding the lock
    
    This patch fixes the problem by creating seperate thread for
    broadcasting the result
    
    > Change-Id: I53be006eadf6aaf348083d9168535530d70a8ab3
    > BUG: 1242819
    > Signed-off-by: vmallika <vmallika>
    
    Change-Id: Ic3c651c143e4143cfb4542d99b4856e582022e36
    BUG: 1257881
    Signed-off-by: vmallika <vmallika>
    Reviewed-on: http://review.gluster.org/12038
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaushal M <kaushal>

Comment 4 Kaushal 2015-09-09 09:41:02 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.4, please open a new bug report.

glusterfs-3.7.4 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12496
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user