Bug 1257894
| Summary: | "rm -rf *" from multiple mount points fails to remove directories on all the subvolumes | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Sakshi <sabansal> |
| Component: | distribute | Assignee: | Sakshi <sabansal> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.7.10 | CC: | bugs, olim, rgowdapp, sabansal, sankarshan, smohan, spalai, spandura |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | dht-rm-rf | ||
| Fixed In Version: | glusterfs-3.7.12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1245065 | Environment: | |
| Last Closed: | 2016-04-19 07:12:36 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1115367, 1245065 | ||
| Bug Blocks: | 960910, 960938, 1128737, 1235633 | ||
|
Description
Sakshi
2015-08-28 10:49:09 UTC
REVIEW: http://review.gluster.org/12040 (dht : lock on subvols to prevent lookup vs rmdir race) posted (#1) for review on release-3.7 by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/13915 (dht: lock on subvols to prevent lookup vs rmdir race) posted (#1) for review on release-3.7 by Sakshi Bansal COMMIT: http://review.gluster.org/13915 committed in release-3.7 by Raghavendra G (rgowdapp) ------ commit b9c37234e0933c836e1bfdb72607b592ea5080c4 Author: Sakshi <sabansal> Date: Thu Jul 16 14:31:03 2015 +0530 dht: lock on subvols to prevent lookup vs rmdir race There is a possibility that while an rmdir is completed on some non-hashed subvol and proceeding to others, a lookup selfheal can recreate the same directory on those subvols for which the rmdir had succeeded. Now the deletion of the parent directory will fail with an ENOTEMPTY. To fix this take blocking inodelk on the subvols before starting rmdir. Selfheal must also take blocking inodelk before creating the entry. Backport of http://review.gluster.org/13528 > Change-Id: I168a195c35ac1230ba7124d3b0ca157755b3df96 > BUG: 1245065 > Signed-off-by: Sakshi <sabansal> > Reviewed-on: http://review.gluster.org/13528 > CentOS-regression: Gluster Build System <jenkins.com> > NetBSD-regression: NetBSD Build System <jenkins.org> > Smoke: Gluster Build System <jenkins.com> > Reviewed-by: Raghavendra G <rgowdapp> > Tested-by: Raghavendra G <rgowdapp> Change-Id: I168a195c35ac1230ba7124d3b0ca157755b3df96 BUG: 1257894 Signed-off-by: Sakshi <sabansal> Reviewed-on: http://review.gluster.org/13915 Smoke: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Raghavendra G <rgowdapp> CentOS-regression: Gluster Build System <jenkins.com> REVIEW: http://review.gluster.org/14025 (mount/fuse: report ESTALE as ENOENT) posted (#1) for review on release-3.7 by N Balachandran (nbalacha) REVIEW: http://review.gluster.org/14027 (mount/fuse: report ESTALE as ENOENT) posted (#1) for review on release-3.7 by Raghavendra G (rgowdapp) This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.11, please open a new bug report. glusterfs-3.7.11 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://www.gluster.org/pipermail/gluster-users/2016-April/026321.html [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user COMMIT: http://review.gluster.org/14027 committed in release-3.7 by Raghavendra G (rgowdapp) ------ commit adc8aeb16cdee8d2f58aa8f2fce1dd637f264e51 Author: Raghavendra G <rgowdapp> Date: Wed Mar 23 13:47:27 2016 +0530 mount/fuse: report ESTALE as ENOENT When the inode/gfid is missing, brick report back as an ESTALE error. However, most of the applications don't accept ESTALE as an error for a file-system object missing, changing their behaviour. For eg., rm -rf ignores ENOENT errors during unlink of files/directories. But with ESTALE error it doesn't send rmdir on a directory if unlink had failed with ESTALE for any of the files or directories within it. BUG: 1257894 Change-Id: I5e56bc0c53f52179940b4691acf6b3db853965df Signed-off-by: Raghavendra G <rgowdapp> Reviewed-on: http://review.gluster.org/14027 Tested-by: N Balachandran <nbalacha> Smoke: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: N Balachandran <nbalacha> CentOS-regression: Gluster Build System <jenkins.com> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.12, please open a new bug report. glusterfs-3.7.12 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://www.gluster.org/pipermail/gluster-devel/2016-June/049918.html [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |