Bug 1258271
| Summary: | Incorrect AuthRecord.VALID_TO value | ||
|---|---|---|---|
| Product: | [oVirt] ovirt-engine-extension-aaa-jdbc | Reporter: | Alon Bar-Lev <alonbl> |
| Component: | General | Assignee: | Martin Perina <mperina> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Ondra Machacek <omachace> |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 1.0.0 | CC: | bugs, iheim, oourfali, pstehlik, rnori, ylavi |
| Target Milestone: | ovirt-3.6.0-rc | Keywords: | CodeChange |
| Target Release: | 1.0.0 | Flags: | ylavi:
ovirt-3.6.0?
rule-engine: planning_ack? rule-engine: devel_ack+ rule-engine: testing_ack+ |
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | infra | ||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-11-04 13:38:06 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Infra | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1258275 | ||
| Bug Blocks: | 1076971 | ||
Side note: please handle all internal time as UTC even in log, I see: 2015-08-31 00:29:11,496 INFO [org.ovirt.engine.extension.aaa.jdbc.core.Tasks] (default task-44) [] (house keeping) deleting failed logins prior to 2015-08-24 00:29:11+03. 2015-08-31 00:29:11,507 DEBUG [org.ovirt.engine.extension.aaa.jdbc.core.Authentication] (default task-44) [] Authenticating subject:admin login time:2015-08-31 00:29:11+03 Confusion may has been created since java parses Z as timezone, while all dates within API should be utc 'Z' timezone. (In reply to Alon Bar-Lev from comment #2) > Confusion may has been created since java parses Z as timezone, while all > dates within API should be utc 'Z' timezone. worse, engine is also effected, see bug#1258275. Please push this forward. So, you want internally aaa-jdbc to work with timestamps in UTC timezone only (all time related fields in db will have UTC timezone set) and all user inputs with different timezones to be converted into UTC, right? (In reply to Martin Perina from comment #5) > So, you want internally aaa-jdbc to work with timestamps in UTC timezone > only (all time related fields in db will have UTC timezone set) and all user > inputs with different timezones to be converted into UTC, right? in extension interface UTC with Z timezone should be provided, this is the minimum required change. Fixed in ovirt-engine-extension-aaa-jdbc-1.0.0-0.0.master.20150923074938.git46a67c9 Fix contained in oVirt 3.6.0 RC1 2015-09-29 11:55:27,483 DEBUG [org.ovirt.engine.extension.aaa.jdbc.core.Authentication] (ajp-/127.0.0.1:8702-10) [] Authenticating subject:admin login time:2015-09-29 09:55:27Z Returning back to assigned, since times are incorrectly stored in DB. In timezone UTC+2 when I login as user at time 12:38, the db record looks like - "2015-10-05 10:38:45.539+02" and should be "2015-10-05 12:38:45.539+02". In the log I can see correct conversion of current login time: 2015-10-05 12:38:45,539 DEBUG [org.ovirt.engine.extension.aaa.jdbc.core.Authentication] (default task-11) [] Authenticating subject:admin login time:2015-10-05 10:38:45Z Fix contained in ovirt-engine-extension-aaa-jdbc-1.0.0 ovirt-engine-extension-aaa-jdbc-1.0.0-2 is contained in oVirt 3.6.0 RC2 OK in ovirt-engine-extension-aaa-jdbc-1.0.0-2.el6ev.noarch Fixed bug tickets must have version flags set prior to fixing them. Please set the correct version flags and move the bugs back to the previous status after this is corrected. oVirt 3.6.0 has been released on November 4th, 2015 and should fix this issue. If problems still persist, please open a new BZ and reference this one. |
By documentation should be: /** * Session valid to. * Application should expire session at most at this time. * Format: "yyyyMMddHHmmssZ". */ public static final ExtKey VALID_TO = new ExtKey("AAA_AUTHN_AUTH_RECORD_VALID_TO", String.class, "b332d076-5f4d-419f-8fdf-015579f4dfa6"); In practice it contains timezone, example: 20150907002911+0300 Causes exception while parsing.