Bug 1258542
| Summary: | Review Request: hack-fonts - A typeface designed for source code | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Helio Chissini de Castro <helio> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED DUPLICATE | QA Contact: | Shawn Starr <shawn.starr> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | 7d28c752, arun, awilliam, benson_muite, devurandom, ego.cordatus, fedora, fonts-bugs, hegjon, herrold, i, jamie.mansfield.jm, jan.public, katyaberezyaka, lantw44, lucachess, mavit, mwhittin, ncross, orschiro, package-review, paul.lipps, rdieter, shawn.starr, stephen, tcarlin, travier |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-01-01 04:43:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1440971, 1441023 | ||
| Bug Blocks: | 201449 | ||
|
Description
Helio Chissini de Castro
2015-08-31 15:21:00 UTC
From the policy: "Fonts SHOULD be built from source whenever upstream provides them in a source format" - upstream does appear to provide source here. Yep They have the source, but no instructions how to build it whatsoever. I just followed the same process used on Overpass Red Hat font, which has the source available, but same way, only the type faces are included. NEW version released. (In reply to Helio Chissini de Castro from comment #2) > Yep > > They have the source, but no instructions how to build it whatsoever. > I just followed the same process used on Overpass Red Hat font, which has > the source available, but same way, only the type faces are included. This is ridiculous, the fonts are derived from DejaVu, and DejaVu build is completely scripted. The project just need to fork the build scripts like it forked everything else, and decide on a naming policy I really hope to see this package in the main repo soon :) Where are we in this review? Upstream is excited to get Hack into Fedora. Updated SPEC and SRPM https://heliocastro.fedorapeople.org/hack/hack-fonts-2.018-1.fc23.src.rpm https://heliocastro.fedorapeople.org/hack/hack-fonts.spec Copr repo updated as well https://copr.fedoraproject.org/coprs/heliocastro/hack-fonts/ Any further update on this? Package request has been denied with the reason: Review not approved. Package request has been denied with the reason: Review not approved. Package request has been denied with the reason: Review not approved. Package request has been denied with the reason: Review not approved. Package request has been denied with the reason: Review not approved. Package request has been denied with the reason: Review not approved. I will do review since I want this font already. Expect a review for tomorrow. I'll just take this over if nobody is doing this, will ask for a review. Thanks Shawn. This was strangely forgotten. Before we can even move to package this, does anyone know how this is built? I've opened a ticket on upstream's github, Debian has this packaged but I don't see them doing any source builds of the fonts. I need some clarification on our policy for this. Given Debian is even more severe for requiring sources, maybe Fedora should follow Debian's guide on this? Debian is using same approach as me, using the precompiled ttf/otf The only thing is that we're deploying only ttf and debian both ones. And i personally don't know if worth pack the web fonts. Well, if it's acceptable to Debian surely this should be acceptable to Fedora, if not something seems wrong with our policy... Debian is not inevitably 'freer' than Fedora. Our requirements are more strict in some ways. Just because Debian doesn't (and, AFAICT, never has) required fonts to be compiled from source doesn't mean we're wrong in requiring this. Upstream bug regarding building this font from source: https://github.com/chrissimpkins/Hack/issues/227 I am in contact with upstream, they are looking at improving our ability to build the fonts from scratch. More on this when they get back to me. The Hack license is now acceptable for Fedora: https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/thread/MJ4Q3D6JLDVX4OHSF3YXY76Z6BYSKKQR/ Also, FWIW I could really use the web fonts for Bodhi (which is why I wanted to package Hack) so I would appreciate if you could include a subpackage with those files. I'm willing to review this package if nobody else has a "claim" on reviewing it. After reading the scrollback it does sound like Shawn is lined up to do the review so I'll defer, but I'm happy to be a standin. I'll memorize my lines. My interpretation of the packaging rules is that SHOULD != MUST when it comes to building the font from source. The font guidelines do use the word "MUST" in other places so I take that to mean that this shouldn't block the package from getting into Fedora. It's obviously better if we build the font from source, but since there isn't a clear way to do that provided by upstream I don't think we have to wait for https://github.com/chrissimpkins/Hack/issues/227 to be solved to get this into Fedora. I would recommend allowing the package in with the OTF files (and hopefully web files for me ☺) and then filing a BZ to build from source if possible later. Well, there's still the *general* packaging guidelines to consider. I don't think the font guidelines supersede those, in fact the section on packaging from source specifically references back to them. And they're quite specific about when you get an exception from the requirement to build from source. I've poked Chris on twitter, you can certainly help with packaging, it's always good to have co-maintainers. Adam, fair enough. Shawn, if you don't want to deal with the web files I'd be happy to handle that part as a co-maintainer. Here is the tool can use to build the fonts https://github.com/GoogleI18N/fontmake We will need this packaged too as a dependency for building, if we want to build them now. Any news here? I should have something soon, i'll put up a .spec for review this week. So I see this is still pending and I'm not completely sure why. I understand that there's a desire to have these built from source, which requires some additional dependencies. However, fonts are considered by Fedora to be "content" and are explicitly listed as content: https://fedoraproject.org/wiki/Packaging:Guidelines#Code_Vs_Content The font-specific packaging guidelines mention that they should be compiled from source because most of the time they are buildable with free, packaged software and the existence of bytecode hinting engines does get close to the line of what might start looking like something which isn't content. However, it's just a "should", and lack of software needed to build it is a pretty good reason to violate one of those. If anything I'd hope that the hack fonts could be imported now while work is ongoing to package the dependencies. In the future this package could switch over to building from source. If the guidelines on this are confusing then I will be happy to work to get them changed to be less confusing. Upstream is changing how fonts are built now, which means we can use Open Source tools to build them. I'm waiting for them to finish some of those bits which are im progress right now. This is currently blocked from our other dependencies needed for python-fontmake and its sub-dependencies... Upstream is appreciative in our efforts to get things packaged up. Note: https://github.com/source-foundry/Hack/blob/master/CHANGELOG.md 3.00 is released, but we're still blocked here... Not forgotten... I am seeing the reviews blocking this are getting closer to being done. I've been working on getting Hack packaged in a satisfactory manor (I hope), its not 100% working yet - trouble at the last step (always the way -_-). My solution to the lack of a 'fontmake' package, is to grab the dependencies from pip (in a virtual environment). This can easily be swapped out for the proper 'fontmake' package when the time comes. This isn't a perfect solution, but it does solve the issue of compiling the font ourselves - input on this would be appreciated :) Hopefully we can get this into the repository swiftly. On a final note, I haven't based this work of the original spec presented in this issue (I'd already begun working on my own) - looking at the original, there does seem to be some outstanding issues with it that are resolved by mine: - The source URL seems be be wrong on the original, referring to an old version (perhaps GitHub allows such dodgy usage) - Some of the metadata seems to be filled in wrong, specifically with regards to the licensing Repository: https://pagure.io/hack-fonts SPEC File: https://pagure.io/hack-fonts/raw/master/f/hack-fonts.spec That's not acceptable under Fedora policies, I don't think. (As written it simply would not *work*, either, when you tried an official package build, as - by design - package builds run without network access). Huh, wasn't aware of the package builds running without network access - will need to wait for fontmake to be introduced to a package then :S At least the work is easily adaptable for when that happens - I'll look into the issue I'm having with ttfautohint and it should be a case of adding the appropriate required package. Yes, this is where we are at and why I've not been able to move on this... Hi everyone, Has anything changed since 2018? Would Hack be a candidate for Fedora 34? > Has anything changed since 2018? > > Would Hack be a candidate for Fedora 34? To make any progress I think we need someone enthusiastic enough to package the Python fontmake tool and/or its outstanding dependencies, and shepherd them all the way through the review process. I don't believe anyone's working on it at the moment. Looks like we can hopefully leverage some work from copr, https://copr.fedorainfracloud.org/coprs/zawertun/hack-fonts/ Any progress on this? Readme for the package seems to indicate it is available https://github.com/source-foundry/Hack#package-managers in dnf-plugins-core :: heliocastro/hack-fonts :: hack-fonts I would like this package for SILE https://sile-typesetter.org/ I created a new package review, see bug #2149686. All the referenced spec/srpm files gives me 404 and this ticket is still in review after 7 years. Can this be closed? Newer ticket https://bugzilla.redhat.com/show_bug.cgi?id=2149686 This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket. *** This bug has been marked as a duplicate of bug 2149686 *** |