Bug 1258547
Summary: | If block disk alias or description is too long, disk metadata will be truncated, causing various failures | ||
---|---|---|---|
Product: | [oVirt] ovirt-engine | Reporter: | Idan Shaby <ishaby> |
Component: | General | Assignee: | Idan Shaby <ishaby> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Eyal Shenitzky <eshenitz> |
Severity: | high | Docs Contact: | |
Priority: | high | ||
Version: | 3.5.0 | CC: | acanan, amureini, bazulay, bugs, ecohen, gklein, lsurette, mgoldboi, nsoffer, rbalakri, tnisan, ycui, yeylon |
Target Milestone: | ovirt-3.6.0-rc | Flags: | rule-engine:
ovirt-3.6.0+
ylavi: planning_ack+ rule-engine: devel_ack+ rule-engine: testing_ack+ |
Target Release: | 3.6.0 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | storage | ||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: |
Cause:
Too long disk alias and/or description used to be sent to vdsm without any check.
Consequence:
vdsm used to truncated them silently and caused a corruption in the volume's metadata.
Fix:
Too long alias and/or description are truncated in the engine side so that the maximum length of the json disk description field sent to vdsm is now limited to 210 bytes.
The priority is given to the alias. That means that we read the alias first, and only if there's enough space, we take a part of/the entire description.
If the alias is too long, it will be truncated and the description will not be sent to vdsm at all.
Result:
There's no corruption in the volume's metadata.
|
Story Points: | --- |
Clone Of: | 1258097 | Environment: | |
Last Closed: | 2015-11-27 07:53:48 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1258097 | ||
Bug Blocks: |
Description
Idan Shaby
2015-08-31 15:31:05 UTC
Tal, are we still waiting for anything for the 3.6 patch? Nope, all is merged 3.6 as well as 3.5.z To verify: 1. Create a storage domain (two scenarios - file and block). 2. Create a disk on that domain with alias and description of specific length (see the doc text for the different cases). 3. Take it down to maintenance and destroy it. 4. Import the storage domain. 5. Register the disk you previously created (http://www.ovirt.org/Features/ImportStorageDomain#Register_an_unregistered_disk). 6. Verify that the disk's alias and description are as expected, i.e. restored fully if they fit or cut if they overflow the max metadata DiskDescription length (210 bytes). Another test can be to follow only steps 1 and 2, and then verify that the disk metadata "DiskDescription" field is a complete and legal json string, i.e.: DiskDescription={...} Note that using too long disk alias/description might fail according to BZ 1280358, so use shorter names to avoid that issue. both test passed. checked on engine version: 3.6.0.3-0.1.el6 Since oVirt 3.6.0 has been released, moving from verified to closed current release. |