Bug 1258727

Summary: performance translators: Pending - porting logging messages to new logging framework
Product: [Community] GlusterFS Reporter: hari gowtham <hgowtham>
Component: loggingAssignee: hari gowtham <hgowtham>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: high    
Version: 3.7.3CC: annair, bugs, gluster-bugs, rhs-bugs, sasundar, vagarwal, vbellur
Target Milestone: ---Keywords: EasyFix, Triaged
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: glusterfs-3.7.5 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1242377 Environment:
Last Closed: 2015-10-14 10:28:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1242377    
Bug Blocks: 1241957, 1253149, 1260923    

Description hari gowtham 2015-09-01 06:38:27 UTC
+++ This bug was initially created as a clone of Bug #1242377 +++

Description of problem:
-----------------------
There are few instances of 'gf_log' as seen under performance_xlators directory in the code base

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
RHGS 3.1 ( glusterfs-3.7.1-8.el6rhs )

Expected results:
-----------------
All gf_log instances should be ported to new logging framework

gf_log instances
-----------------
io-cache/src/ioc-inode.c:   gf_log ("io-cache", GF_LOG_WARNING,
io-cache/src/ioc-inode.c-   "asprintf failed while converting ptr to str");
--
io-cache/src/ioc-inode.c:   gf_log (frame->this->name, GF_LOG_WARNING,
io-cache/src/ioc-inode.c-   "cache validate called without any "
--
io-cache/src/page.c:        gf_log (frame->this->name, GF_LOG_WARNING,
io-cache/src/page.c-         "wasted copy: %"PRId64"[+%"PRId64"] "
--
quick-read/src/quick-read.c:  gf_log ("quick-read", GF_LOG_INFO,
quick-read/src/quick-read.c-    "quick read inode table lru not empty");
--
read-ahead/src/read-ahead.c:  gf_log (this->name, GF_LOG_WARNING, "conf null in xlator");
read-ahead/src/read-ahead.c-   goto out;
--
read-ahead/src/read-ahead.c:  gf_log (this->name, GF_LOG_INFO,
read-ahead/src/read-ahead.c-  "undestroyed read ahead file structures found");
--
symlink-cache/src/symlink-cache.c: gf_log (this->name, GF_LOG_ERROR,
symlink-cache/src/symlink-cache.c-	"out of memory :(");

Comment 1 Anand Avati 2015-09-01 07:26:25 UTC
REVIEW: http://review.gluster.org/12073 (performance translators : port missing gf_log to gf_msg) posted (#2) for review on release-3.7 by hari gowtham (hari.gowtham005)

Comment 2 Anand Avati 2015-09-01 10:23:23 UTC
REVIEW: http://review.gluster.org/12073 (performance translators : port the missing gf_log to gf_msg) posted (#3) for review on release-3.7 by hari gowtham (hari.gowtham005)

Comment 3 Vijay Bellur 2015-09-03 11:10:38 UTC
REVIEW: http://review.gluster.org/12073 (performance translators : port the missing gf_log to gf_msg) posted (#6) for review on release-3.7 by hari gowtham (hari.gowtham005)

Comment 4 Vijay Bellur 2015-09-08 05:11:17 UTC
REVIEW: http://review.gluster.org/12073 (performance translators : port the missing gf_log to gf_msg) posted (#7) for review on release-3.7 by hari gowtham (hari.gowtham005)

Comment 6 Pranith Kumar K 2015-10-14 10:28:17 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-glusterfs-3.7.5, please open a new bug report.

glusterfs-glusterfs-3.7.5 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/gluster-users/2015-October/023968.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 7 Pranith Kumar K 2015-10-14 10:37:44 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.5, please open a new bug report.

glusterfs-3.7.5 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/gluster-users/2015-October/023968.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user