Bug 1258797

Summary:	Revert back the TransactionLockInterceptor default to "false" for SingletonRuntimeManager
Product:	[Retired] JBoss BPMS Platform 6	Reporter:	Toshiya Kobayashi <tkobayas>
Component:	jBPM Core	Assignee:	Alessandro Lazarotti <alazarot>
Status:	CLOSED EOL	QA Contact:	Marián Macik <mmacik>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	6.1.0	CC:	mmacik
Target Milestone:	ER4
Target Release:	6.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1258804 (view as bug list)		Environment:
Last Closed:	2020-03-27 20:12:00 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1258804

Description Toshiya Kobayashi 2015-09-01 10:12:43 UTC

Description of problem:

In BZ1161574, TransactionLockInterceptor is enabled by for SingletonRuntimeManager. But actually, with proper use of taskService (= take SynchronizedTaskService from Singleton RuntimeEngine), the "disconnected" issue will not happen. So "disabled" is the right default behaviour.

Steps to Reproduce:
1. Set DEBUG level log for org.drools.persistence.jta.TransactionLockInterceptor

            <logger category="org.drools.persistence.jta.TransactionLockInterceptor">
                <level name="DEBUG"/>
	    </logger>
 
2. Build&Deploy a project with a process which has a UserTask in business-central
3. Start a process. Complete a Task.
4. Look at server.log

Actual results:

You find TransactionLockInterceptor activities at DEBUG level.

19:02:12,404 DEBUG [org.drools.persistence.jta.TransactionLockInterceptor] (pool-19-thread-1) About to register lock release handler by pool-19-thread-1
19:02:12,404 DEBUG [org.drools.persistence.jta.TransactionLockInterceptor] (pool-19-thread-1) Error happened releasing directly by pool-19-thread-1 due to No transaction is running
19:02:12,404 DEBUG [org.drools.persistence.jta.TransactionLockInterceptor] (pool-19-thread-1) Releasing on transaction completion by pool-19-thread-1
19:02:12,404 DEBUG [org.drools.persistence.jta.TransactionLockInterceptor] (pool-19-thread-1) Successfully released lock by pool-19-thread-1
19:02:12,404 DEBUG [org.drools.persistence.jta.TransactionLockInterceptor] (pool-19-thread-1) About to get a lock on command service by pool-19-thread-1
19:02:12,404 DEBUG [org.drools.persistence.jta.TransactionLockInterceptor] (pool-19-thread-1) Lock taken by pool-19-thread-1
19:02:12,405 DEBUG [org.drools.persistence.jta.TransactionLockInterceptor] (pool-19-thread-1) About to register lock release handler by pool-19-thread-1
19:02:12,405 DEBUG [org.drools.persistence.jta.TransactionLockInterceptor] (pool-19-thread-1) Error happened releasing directly by pool-19-thread-1 due to No transaction is running
19:02:12,405 DEBUG [org.drools.persistence.jta.TransactionLockInterceptor] (pool-19-thread-1) Releasing on transaction completion by pool-19-thread-1
19:02:12,405 DEBUG [org.drools.persistence.jta.TransactionLockInterceptor] (pool-19-thread-1) Successfully released lock by pool-19-thread-1



Expected results:

You only see "Transaction lock interceptor enabled false" logs.

19:01:30,614 DEBUG [org.drools.persistence.jta.TransactionLockInterceptor] (http-localhost.localdomain/127.0.0.1:8080-11) Transaction lock interceptor enabled false
19:01:30,615 DEBUG [org.drools.persistence.jta.TransactionLockInterceptor] (http-localhost.localdomain/127.0.0.1:8080-11) Transaction lock interceptor enabled false
19:01:30,623 DEBUG [org.drools.persistence.jta.TransactionLockInterceptor] (http-localhost.localdomain/127.0.0.1:8080-11) Transaction lock interceptor enabled false
19:01:30,634 DEBUG [org.drools.persistence.jta.TransactionLockInterceptor] (http-localhost.localdomain/127.0.0.1:8080-11) Transaction lock interceptor enabled false

Comment 1 Toshiya Kobayashi 2015-09-01 10:23:45 UTC

It was enabled by commits in the comment https://bugzilla.redhat.com/show_bug.cgi?id=1161574#c5

Comment 2 Maciej Swiderski 2015-09-01 14:35:51 UTC

done on master and 6.3.x:

jbpm
master:
https://github.com/droolsjbpm/jbpm/commit/b9176ce9942b2f76259df918c7ee7e6cdb7fb923

6.3.x:
https://github.com/droolsjbpm/jbpm/commit/74d2ef15a96db35056e149e5213e1f943b2401a8

Comment 3 Marián Macik 2015-11-16 11:41:45 UTC

Verified with 6.2.0.ER5.