Bug 1258868

Summary: [RFE] dbus should reload configuration automatically (inotify)
Product: Red Hat Enterprise Linux 7 Reporter: Miroslav Vadkerti <mvadkert>
Component: dbusAssignee: David King <dking>
Status: CLOSED WONTFIX QA Contact: Desktop QE <desktop-qa-list>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.1CC: eedri, jeder, jskarvad, mclasen, msekleta, pablo.iranzo, tcerna
Target Milestone: rcKeywords: FutureFeature
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-09-11 17:32:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1218420    

Description Miroslav Vadkerti 2015-09-01 12:30:13 UTC 
Description of problem:
Currently when a new dbus configuration file is added by a newly installed application - dbus must be restarted to take the changes into affect.

Dbus should use inotify to monitor its configuration paths and reload the configuration automatically. For example polkit does this.

Version-Release number of selected component (if applicable):
dbus-1.6.12-13.el7

How reproducible:
100%

Steps to Reproduce:
1. Add new configuration file

Actual results:
Dbus reloads config automatically

Expected results:
Dbus runtime config not changed
Comment 1 Michal Sekletar 2015-09-02 10:56:29 UTC 
I don't think this is the right approach. In order for new configuration to take effect daemon must be *explicitly* asked to do so. Config must not be applied right after admin hits save in $EDITOR.

Also note that D-Bus demon supports partial reload of its configuration, man page says following,

"SIGHUP  will cause the D-Bus daemon to PARTIALLY reload its configuration file and to flush its user/group information caches. Some configuration changes would require kicking all apps off the bus; so they will only take effect if you restart the daemon. Policy changes should take effect with SIGHUP."
Comment 2 Miroslav Vadkerti 2016-01-13 08:07:48 UTC 
(In reply to Michal Sekletar from comment #1)
> I don't think this is the right approach. In order for new configuration to
> take effect daemon must be *explicitly* asked to do so. Config must not be
> applied right after admin hits save in $EDITOR.

I do not mind if the reload would be explicit.

> 
> Also note that D-Bus demon supports partial reload of its configuration, man
> page says following,

Unfortunately does not work at all for me (I am trying to add a new dbus service file which I do not find a very intrusive operation), see bug 1258865

> 
> "SIGHUP  will cause the D-Bus daemon to PARTIALLY reload its configuration
> file and to flush its user/group information caches. Some configuration
> changes would require kicking all apps off the bus; so they will only take
> effect if you restart the daemon. Policy changes should take effect with
> SIGHUP."
Comment 4 David King 2016-02-16 13:51:49 UTC 
*** Bug 1308549 has been marked as a duplicate of this bug. ***
Comment 8 Matthias Clasen 2019-09-11 17:32:29 UTC 
D-Bus behaves as documented. We can't just change this behavior.