Bug 1259172 (icewind/smb)
| Summary: | Review Request: php-icewind-smb - php wrapper for smbclient and libsmbclient-php | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> | ||||||||
| Component: | Package Review | Assignee: | Shawn Iwinski <shawn> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | rawhide | CC: | package-review, shawn | ||||||||
| Target Milestone: | --- | Flags: | shawn:
fedora-review+
gwync: fedora-cvs+ |
||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2015-10-03 17:52:12 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | 1258955 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Remi Collet
2015-09-02 06:51:46 UTC
Created attachment 1075319 [details]
phpcompatinfo-full.log
phpCompatInfo version 4.4.0 DB built Jul 20 2015 15:06:38 CEST
Created attachment 1075320 [details]
phpcompatinfo-lib.log
phpCompatInfo version 4.4.0 DB built Jul 20 2015 15:06:38 CEST
Created attachment 1075321 [details]
fedora-review.txt
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1259172
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[!]: Buildroot is not present
Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
As usual, remove EPEL 5 bits after initial import. No blocker.
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/php/Icewind(php-
icewind-streams)
Since php-composer(icewind/streams) is a requirement, must remove
%dir %{_datadir}/php/%{ns_vendor}
[!]: Package does not own files or directories owned by other packages. Goot catch! Fix: https://github.com/remicollet/remirepo/commit/a55e669f94800d3db6ece729b92b60dba539d571 Spec: https://raw.githubusercontent.com/remicollet/remirepo/a55e669f94800d3db6ece729b92b60dba539d571/php/php-icewind-smb/php-icewind-smb.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-icewind-smb-1.0.4-2.remi.src.rpm [x]: Package does not own files or directories owned by other packages. Fixed. No blockers. ===== APPROVED ===== Thanks!! New Package SCM Request ======================= Package Name: php-icewind-smb Short Description: php wrapper for smbclient and libsmbclient-php Upstream URL: https://github.com/icewind1991/SMB Owners: remi Branches: f22 f23 epel7 InitialCC: Git done (by process-git-requests). php-icewind-smb-1.0.4-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8170 php-icewind-smb-1.0.4-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16294 php-icewind-smb-1.0.4-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update php-icewind-smb' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16293 php-icewind-smb-1.0.4-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update php-icewind-smb' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16294 php-icewind-smb-1.0.4-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update php-icewind-smb' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8170 php-icewind-smb-1.0.4-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. php-icewind-smb-1.0.4-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. php-icewind-smb-1.0.4-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |