Bug 1259790

New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=2d8e2e992e699c0c14f3358daa6ba979ce412485

commit 2d8e2e992e699c0c14f3358daa6ba979ce412485
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon Sep 28 11:20:38 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Mon Sep 28 11:32:30 2015 -0400

    let caller method render flash message for sublist screens.
    
    - Fixed respective 'button' methods to render flash message partial when task(clone,migrate,publish) are not supported for selected items when user trees to perform these tasks from list of VMs thru relationships. render_flash_not_applicable_to_model will only render flash message when performing tasks directly from VM explorers.
    - Added spec test to verify fix.
    - Moved common code in controllers into a single method.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1263326
    https://bugzilla.redhat.com/show_bug.cgi?id=1259790

 vmdb/app/controllers/application_controller.rb     | 39 ++++++++++++++++++++--
 .../controllers/availability_zone_controller.rb    | 16 +--------
 vmdb/app/controllers/cim_instance_controller.rb    | 16 +--------
 vmdb/app/controllers/cloud_tenant_controller.rb    | 20 +----------
 vmdb/app/controllers/ems_cluster_controller.rb     | 16 +--------
 vmdb/app/controllers/ems_common.rb                 | 16 +--------
 vmdb/app/controllers/flavor_controller.rb          | 16 +--------
 vmdb/app/controllers/host_controller.rb            | 12 ++++++-
 .../controllers/orchestration_stack_controller.rb  | 20 +----------
 vmdb/app/controllers/repository_controller.rb      | 16 +--------
 vmdb/app/controllers/resource_pool_controller.rb   | 32 +++++-------------
 vmdb/app/controllers/security_group_controller.rb  | 16 +--------
 vmdb/app/controllers/storage_controller.rb         | 16 +--------
 .../controllers/application_controller_spec.rb     |  1 -
 .../spec/controllers/ems_common_controller_spec.rb | 30 +++++++++++++++++
 15 files changed, 97 insertions(+), 185 deletions(-)

New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=8c6a6f47fdfceb3a19b7fec80a6117dd003b1ce5

commit 8c6a6f47fdfceb3a19b7fec80a6117dd003b1ce5
Merge: a69c2fd 2d8e2e9
Author:     Dan Clarizio <dclarizi>
AuthorDate: Mon Sep 28 12:25:40 2015 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Mon Sep 28 12:25:40 2015 -0400

    Merge branch '54z_bz_1259790' into '5.4.z'
    
    let caller method render flash message for sublist screens.
    
    - Fixed respective 'button' methods to render flash message partial when task(clone,migrate,publish) are not supported for selected items when user trees to perform these tasks from list of VMs thru relationships. render_flash_not_applicable_to_model will only render flash message when performing tasks directly from VM explorers.
    - Added spec test to verify fix.
    - Moved common code in controllers into a single method.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1263326
    https://bugzilla.redhat.com/show_bug.cgi?id=1259790
    
    @dclarizi please review, a clean patch was applied. Original PR: https://github.com/ManageIQ/manageiq/pull/4368
    
    See merge request !270

 vmdb/app/controllers/application_controller.rb     | 39 ++++++++++++++++++++--
 .../controllers/availability_zone_controller.rb    | 16 +--------
 vmdb/app/controllers/cim_instance_controller.rb    | 16 +--------
 vmdb/app/controllers/cloud_tenant_controller.rb    | 20 +----------
 vmdb/app/controllers/ems_cluster_controller.rb     | 16 +--------
 vmdb/app/controllers/ems_common.rb                 | 16 +--------
 vmdb/app/controllers/flavor_controller.rb          | 16 +--------
 vmdb/app/controllers/host_controller.rb            | 12 ++++++-
 .../controllers/orchestration_stack_controller.rb  | 20 +----------
 vmdb/app/controllers/repository_controller.rb      | 16 +--------
 vmdb/app/controllers/resource_pool_controller.rb   | 32 +++++-------------
 vmdb/app/controllers/security_group_controller.rb  | 16 +--------
 vmdb/app/controllers/storage_controller.rb         | 16 +--------
 .../controllers/application_controller_spec.rb     |  1 -
 .../spec/controllers/ems_common_controller_spec.rb | 30 +++++++++++++++++
 15 files changed, 97 insertions(+), 185 deletions(-)

Using 5.4.2 on (https://10.8.59.82/ems_infra/show/124000000000054?display=miq_templates) I reproduced the error and verified it inside the production.log.

Next, using 5.4.3 on (https://10.8.59.221/ems_infra/show/1001000000000001?display=miq_templates) I was not able to reproduce the error.  The correct flash message appeared and no adverse entries were observed in the log files.

Moving to Verified as this issue appears to be resolved.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1916.html