Bug 1259840

Summary:	[GSS](6.4.z) Remove caching of the value of isTraceEnabled for JCA infrastructure
Product:	[JBoss] JBoss Enterprise Application Platform 6	Reporter:	jolee
Component:	JCA	Assignee:	baranowb <bbaranow>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Martin Simka <msimka>
Severity:	high	Docs Contact:
Priority:	high
Version:	6.4.4	CC:	bbaranow, bmaxwell, istudens, jawilson, jolee, jpederse
Target Milestone:	CR1
Target Release:	EAP 6.4.6
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1235746, 1275283

Description jolee 2015-09-03 15:26:20 UTC

Description of problem:
   caching the value of isTraceEnabled does not allow for complete dynamic control of the logging level.  This has ramifications in support scenarios where diagnostics are needed and the ability to reload an instance to enable TRACE level logging is prohibitive.

see examples of TRACE being cached (similar to below in https://github.com/ironjacamar/ironjacamar/tree/1.0):
grep 'log.isTraceEnabled();' -r * --include='*.java'

Replacement of all if (trace) with calls to log.tracef would be needed.



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Jesper Pedersen 2015-09-04 11:30:36 UTC

Note, that some "if (trace)" would have to be replaced by if (log.isTraceEnabled()) calls, as they guard multiple lines of code, and even synchronization blocks

Comment 14 JBoss JIRA Server 2015-12-10 14:19:41 UTC

Jesper Pedersen <jpederse> updated the status of jira JBJCA-1294 to Resolved

Comment 15 JBoss JIRA Server 2015-12-10 14:29:53 UTC

Jesper Pedersen <jpederse> updated the status of jira JBJCA-1294 to Closed

Comment 17 Martin Simka 2016-01-20 11:39:17 UTC

verified with EAP 6.4.6.CP.CR2

Comment 18 Petr Penicka 2017-01-17 11:47:19 UTC

Retroactively bulk-closing issues from released EAP 6.4 cumulative patches.

Comment 19 Petr Penicka 2017-01-17 11:48:06 UTC

Retroactively bulk-closing issues from released EAP 6.4 cumulative patches.