Bug 1260133

Summary: Review Request: python-XStatic-bootswatch - bootswatch (XStatic packaging standard)
Product: [Fedora] Fedora Reporter: Javier Peña <jpena>
Component: Package ReviewAssignee: Matthias Runge <mrunge>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: mrunge, package-review
Target Milestone: ---Flags: mrunge: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 3.3.5.3-2.fc23 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-09-11 17:21:10 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Javier Peña 2015-09-04 13:53:09 UTC
Spec URL: https://jpena.fedorapeople.org/python-XStatic-bootswatch/python-XStatic-bootswatch.spec
SRPM URL: https://jpena.fedorapeople.org/python-XStatic-bootswatch/python-XStatic-bootswatch-3.3.5.3-1.fc24.src.rpm
Description: bootswatch javascript library packaged
for setuptools (easy_install) / pip.
Fedora Account System Username: jpena

Koji scratch build available at http://koji.fedoraproject.org/koji/taskinfo?taskID=10955370

I'm following the same concept used in https://bugzilla.redhat.com/show_bug.cgi?id=1260038 (python2 and python3 subpackages, with bootswatch-common package for css/scss and fonts), so this could change as a result of the other review.

Comment 1 Matthias Runge 2015-09-04 14:35:55 UTC
I'll do a review

Comment 2 Matthias Runge 2015-09-07 10:33:31 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 4 files have unknown license. Detailed
     output of licensecheck in /home/mrunge/review/1260133-python-XStatic-
     bootswatch/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/fonts
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[!]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
     -XStatic-bootswatch , bootswatch-common , python3-XStatic-bootswatch
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[!]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python2-XStatic-bootswatch-3.3.5.3-1.fc24.noarch.rpm
          bootswatch-common-3.3.5.3-1.fc24.noarch.rpm
          python3-XStatic-bootswatch-3.3.5.3-1.fc24.noarch.rpm
          python-XStatic-bootswatch-3.3.5.3-1.fc24.src.rpm
python2-XStatic-bootswatch.noarch: W: summary-not-capitalized C bootswatch (XStatic packaging standard)
python2-XStatic-bootswatch.noarch: W: spelling-error %description -l en_US javascript -> java script, java-script, JavaScript
python2-XStatic-bootswatch.noarch: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, toadstools
python2-XStatic-bootswatch.noarch: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
python2-XStatic-bootswatch.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/xstatic/pkg/bootswatch/data/.bowerrc
bootswatch-common.noarch: W: summary-not-capitalized C bootswatch (XStatic packaging standard) common files
python3-XStatic-bootswatch.noarch: W: summary-not-capitalized C bootswatch (XStatic packaging standard)
python3-XStatic-bootswatch.noarch: W: spelling-error %description -l en_US javascript -> java script, java-script, JavaScript
python3-XStatic-bootswatch.noarch: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, toadstools
python3-XStatic-bootswatch.noarch: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
python3-XStatic-bootswatch.noarch: W: hidden-file-or-dir /usr/lib/python3.4/site-packages/xstatic/pkg/bootswatch/data/.bowerrc
python-XStatic-bootswatch.src: W: summary-not-capitalized C bootswatch (XStatic packaging standard)
python-XStatic-bootswatch.src: W: spelling-error %description -l en_US javascript -> java script, java-script, JavaScript
python-XStatic-bootswatch.src: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, toadstools
python-XStatic-bootswatch.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
4 packages and 0 specfiles checked; 0 errors, 15 warnings.




Rpmlint (installed packages)
----------------------------
python2-XStatic-bootswatch.noarch: W: summary-not-capitalized C bootswatch (XStatic packaging standard)
python2-XStatic-bootswatch.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/xstatic/pkg/bootswatch/data/.bowerrc
python3-XStatic-bootswatch.noarch: W: summary-not-capitalized C bootswatch (XStatic packaging standard)
python3-XStatic-bootswatch.noarch: W: hidden-file-or-dir /usr/lib/python3.4/site-packages/xstatic/pkg/bootswatch/data/.bowerrc
bootswatch-common.noarch: W: summary-not-capitalized C bootswatch (XStatic packaging standard) common files
3 packages and 0 specfiles checked; 0 errors, 5 warnings.



Requires
--------
python2-XStatic-bootswatch (rpmlib, GLIBC filtered):
    bootswatch-common
    python(abi)
    python-XStatic

python3-XStatic-bootswatch (rpmlib, GLIBC filtered):
    bootswatch-common
    python(abi)
    python3-XStatic

bootswatch-common (rpmlib, GLIBC filtered):
    web-assets-filesystem



Provides
--------
python2-XStatic-bootswatch:
    python-XStatic-bootswatch
    python2-XStatic-bootswatch

python3-XStatic-bootswatch:
    python3-XStatic-bootswatch

bootswatch-common:
    bootswatch-common



Source checksums
----------------
https://pypi.python.org/packages/source/X/XStatic-bootswatch/XStatic-bootswatch-3.3.5.3.tar.gz :
  CHECKSUM(SHA256) this package     : 3c018cb0fdf591a520b2832a4ba8d8face633c765f29f9ccca8275b47be8aa94
  CHECKSUM(SHA256) upstream package : 3c018cb0fdf591a520b2832a4ba8d8face633c765f29f9ccca8275b47be8aa94


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1260133
Buildroot used: fedora-rawhide-x86_64


- Could you please add
Requires: fontpackages-filesystem 
to bootswatch-common (to have an owner to /usr/share/fonts )

- could you please adjust requirements?
[!]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
     -XStatic-bootswatch , bootswatch-common , python3-XStatic-bootswatch
When installing python-XStatic-bootswatch, you'll get nothing from python2-XStatic-bootswatch installed....

- I would truncate the package description:

bootswatch javascript library packaged
for setuptools (easy_install) / pip.

Free themes for Bootstrap

- please package fonts into a separate 
bootswatch-fonts 
subpackage

Comment 4 Matthias Runge 2015-09-07 13:29:35 UTC
Thank you, after conversation over IRC, newly submitted version looks better.


package APPROVED.

Comment 5 Javier Peña 2015-09-07 14:02:05 UTC
New Package SCM Request
=======================
Package Name: python-XStatic-bootswatch
Short Description: bootswatch (XStatic packaging standard)
Upstream URL: http://bootswatch.com
Owners: jpena mrunge
Branches: f21 f22 f23 epel7
InitialCC:

Comment 6 Gwyn Ciesla 2015-09-07 23:25:12 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2015-09-09 08:25:55 UTC
python-XStatic-bootswatch-3.3.5.3-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8007

Comment 8 Fedora Update System 2015-09-09 08:28:58 UTC
python-XStatic-bootswatch-3.3.5.3-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15423

Comment 9 Fedora Update System 2015-09-09 08:32:14 UTC
python-XStatic-bootswatch-3.3.5.3-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15424

Comment 10 Fedora Update System 2015-09-09 23:50:36 UTC
python-XStatic-bootswatch-3.3.5.3-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update python-XStatic-bootswatch'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8007

Comment 11 Fedora Update System 2015-09-10 02:07:37 UTC
python-XStatic-bootswatch-3.3.5.3-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update python-XStatic-bootswatch'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15424

Comment 12 Fedora Update System 2015-09-10 05:51:44 UTC
python-XStatic-bootswatch-3.3.5.3-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update python-XStatic-bootswatch'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15423

Comment 13 Fedora Update System 2015-09-11 17:21:09 UTC
python-XStatic-bootswatch-3.3.5.3-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2015-09-18 18:30:55 UTC
python-XStatic-bootswatch-3.3.5.3-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.