Bug 1260667

Summary: php: buffer over-read in exif_read_data with TIFF IFD tags
Product: [Other] Security Response Reporter: Adam Mariš <amaris>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED WONTFIX QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: unspecifiedCC: bleanhar, ccoleman, dmcphers, fedora, jdetiber, jialiu, jkeck, jokerman, jorton, kseifried, lmeyer, mmaslano, mmccomas, rcollet, webstack-team
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: php 5.4.45, php 5.5.29, php 5.6.13 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-09-30 14:15:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1260668    
Bug Blocks: 1260756    

Description Adam Mariš 2015-09-07 12:28:25 UTC
When supplying a TIFF file that has a tag for one of Make, Model, or Copyright, where the value is exactly 32 bytes (with no null bytes), a buffer over-read occurs. This will cause a crash to happen when compiled with ASAN, or potential data leak when not.

Upstream report:

https://bugs.php.net/bug.php?id=70385

Upstream patch:

http://git.php.net/?p=php-src.git;a=commit;h=64043cb9e5d8bc5af719678893e38ee0290e0c0a

Comment 1 Adam Mariš 2015-09-07 12:29:05 UTC
Created php tracking bugs for this issue:

Affects: fedora-all [bug 1260668]

Comment 2 Fedora Update System 2015-09-14 22:19:46 UTC
php-5.6.13-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.

Comment 3 Fedora Update System 2015-09-14 23:18:39 UTC
php-5.6.13-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 4 Fedora Update System 2015-09-18 18:41:29 UTC
php-5.6.13-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 5 Tomas Hoger 2015-09-30 14:15:59 UTC
There are actually 2 commits related to this issue:

http://git.php.net/?p=php-src.git;a=commitdiff;h=64043cb9e5d8bc5af719678893e38ee0290e0c0a
http://git.php.net/?p=php-src.git;a=commitdiff;h=ce2c67c8e88ede70a3fe837a484fddc77aba4bb2

It's an over read in string copying of a string that is not properly NUL terminated.  Over read stops at the first \0 encountered.

Given the limited impact, there is currently no plan to backport this fix.  Affected products may get this patches if PHP packages are rebased to newer upstream version in the future.