Bug 1261056

Summary:	Place bonding-defaults.json outside of /var/lib/vdsm
Product:	[oVirt] vdsm	Reporter:	Fabian Deutsch <fdeutsch>
Component:	General	Assignee:	Ondřej Svoboda <osvoboda>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Meni Yakove <myakove>
Severity:	low	Docs Contact:
Priority:	medium
Version:	---	CC:	bazulay, bugs, cshao, danken, gklein, leiwang, lsurette, mburman, osvoboda, srevivo, yaniwang, ycui, ykaul
Target Milestone:	ovirt-4.0.0-alpha	Flags:	rule-engine: ovirt-4.0.0+ rule-engine: planning_ack+ danken: devel_ack+ rule-engine: testing_ack+
Target Release:	4.17.999
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt 4.0.0 alpha1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-07-05 07:52:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Network	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1260746

Description Fabian Deutsch 2015-09-08 13:47:37 UTC

Description of problem:
bonding-defaults.json (https://gerrit.ovirt.org/gitweb?p=vdsm.git;a=blob;f=vdsm/bonding-defaults.json;hb=HEAD) provides some defaults for bonds.
As these are vendor/vdsm provided defaults it should not live inside /var/lib, rather in /usr/lib where a vendor can put his defaults.

/etc/vdsm/bonding-defaults.json could then be a place, which a user can use to override the defaults provided by vdsm.

Comment 1 Dan Kenigsberg 2015-11-29 10:33:55 UTC

Some background: this bug was opened when testing Vdsm in a container, where /var/lib is created afresh on startup.

/var/lib/vdsm/bonding-defaults.json is shipped with Vdsm only because creating it on Vdsm startup has conflicted with a currently-running NetworkManager (see commit message of http://gerrit.ovirt.org/33403).

Until NetworkManager is convinced not to touche our reference bond, we'd better move the json file to /usr/lib/vdsm.

Comment 3 Mike McCune 2016-03-28 23:15:27 UTC

This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 4 Michael Burman 2016-04-10 08:33:30 UTC

Hi 

How this bug should be tested? Thanks

Comment 5 Dan Kenigsberg 2016-04-10 10:07:27 UTC

verify that `rpm -ql vdsm |grep /var/lib/vdsm` is empty, yet `vdsm-tool dump-bonding` works, as well as Vdsm as a whole.

Comment 6 Michael Burman 2016-04-11 14:43:39 UTC

Verified on - vdsm-4.17.999-909.git28d724a.el7.centos.noarch

Comment 7 Sandro Bonazzola 2016-07-05 07:52:34 UTC

oVirt 4.0.0 has been released, closing current release.