Bug 1261091

Summary: puppet fails if hiera datadir is overriden
Product: [Fedora] Fedora Reporter: Lukas Bezdicka <lbezdick>
Component: puppetAssignee: Jeroen van Meeuwen <vanmeeuwen+fedora>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 22CC: dcleal, fedora, gchamoul, jose.p.oliveira.oss, k.georgiou, lzap, marianne, mastahnke, mmagr, moses, s, tmz, vanmeeuwen+fedora
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 4.1.0-5.fc22 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-09-18 18:30:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Lukas Bezdicka 2015-09-08 14:39:52 UTC
Description of problem:
If you change datadir in /etc/puppet/hiera.yaml puppet will fail to load the path.

  :datadir: /var/tmp/packstack/8b965aebdf8e445087bd19502bc7ae77/hieradata

This is due to safe_yaml library default_mode set to :safe which escapes the loaded yaml. Puppet does not expect this and previous fix in hiera was wrong as it should use load_file instead unsafe_load_file (see https://bugzilla.redhat.com/show_bug.cgi?id=1242676).


Version-Release number of selected component (if applicable):


How reproducible:
Always

Additional info:
Please add line "SafeYAML::OPTIONS[:default_mode] = :unsafe" to puppet/vendor/require_vendored.rb

Comment 1 Martin Magr 2015-09-08 16:09:42 UTC
Looking at the source, it seems safe_yaml is removed. Also according to [1] it seems it is removed. I believe we should remove hardcoded usage of the vendored lib and the issue will be fixed.


[1] https://tickets.puppetlabs.com/browse/PUP-3272
[2] bz#1198366

Comment 2 Fedora Update System 2015-09-09 09:17:53 UTC
puppet-4.1.0-5.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15429

Comment 3 Fedora Update System 2015-09-09 09:25:24 UTC
puppet-4.2.1-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15430

Comment 4 Fedora Update System 2015-09-10 02:07:34 UTC
puppet-4.1.0-5.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update puppet'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15429

Comment 5 Fedora Update System 2015-09-10 05:51:41 UTC
puppet-4.2.1-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update puppet'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15430

Comment 6 Fedora Update System 2015-09-18 18:30:52 UTC
puppet-4.2.1-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2015-09-24 08:25:25 UTC
puppet-4.1.0-5.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.