Bug 1261566

Summary:	use ioctl(SIOC[GS]IFHWADDR) to save/set MAC address of macvtap passthrough physdevs with an 802.1Qbh port profile
Product:	Red Hat Enterprise Linux 6	Reporter:	Laine Stump <laine>
Component:	libvirt	Assignee:	Laine Stump <laine>
Status:	CLOSED DUPLICATE	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	6.7	CC:	dyuan, honzhang, jdenemar, lmiksik, mzhan, rbalakri, sassmann, virt-bugs
Target Milestone:	rc	Keywords:	Regression
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1257004	Environment:
Last Closed:	2015-09-30 17:18:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Laine Stump 2015-09-09 17:11:02 UTC

+++ This bug was initially created as a clone of Bug #1257004 +++

Before libvirt sets the MAC address of the physdev (the physical ethernet device) linked to a macvtap passthrough device, it always saves the previous MAC address to restore when the guest is finished (following a "leave nothing behind" policy). It has even done this for macvtap devices that have an 802.1Qbh port profile attached to them. It turns out that this is unnecessary, because the port profile Associate/Disassociate operations do that for us.

Beyond that, with a recent change to the way we retrieve the MAC address (new in RHEL6.7, thanks to the fix for Bug 1113474, all attempts to start a macvtap passthrough device with an 802.1Qbh port profile attached to a Cisco VMFEX card (which uses the "enic" driver in the kernel) will fail.

--- Additional comment from Laine Stump on 2015-09-03 11:47:04 EDT ---

Fix pushed upstream:

commit 3ce08fab8477da2c76918329523a5e6a312cef06
Author: Laine Stump <laine>
Date:   Mon Aug 31 17:09:01 2015 -0400

    util: make virNetDev(Replace|Restore)MacAddress public functions
    
commit 46cf0cefa0168a0d929ca87010f59e1cba6c689b
Author: Laine Stump <laine>
Date:   Wed Aug 26 00:18:26 2015 -0400

    util: don't use netlink to save/set mac for macvtap+passthrough+802.1Qbh