Bug 1261841

Summary: [HC] Implement fallocate, discard and zerofill with sharding
Product: [Community] GlusterFS Reporter: SATHEESARAN <sasundar>
Component: shardingAssignee: Krutika Dhananjay <kdhananj>
Status: CLOSED CURRENTRELEASE QA Contact: bugs <bugs>
Severity: high Docs Contact:
Priority: high    
Version: mainlineCC: bugs, sabose
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: glusterfs-3.8rc2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1299712 1302688 (view as bug list) Environment:
RHEL 7.1 - converged setup of virt & gluster
Last Closed: 2016-06-16 13:36:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1299712, 1302688    

Description SATHEESARAN 2015-09-10 09:53:46 UTC
Description of problem:
-----------------------
fallocate on the sharded volume fails with "transport endpoint not connected" - ENOTCONN

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
mainline & release-3.7.4

How reproducible:
-----------------
Always

Steps to Reproduce:
-------------------
1. Try fallocate command on the sharded gluster volume

Actual results:
---------------
fallocate failed with "Transport endpoint not connected"

Expected results:
-----------------
fallocate should sucessfully create files

Additional info:
----------------
fallocate will be used by qemu for creating preallocated image files

Comment 1 SATHEESARAN 2015-09-10 09:54:34 UTC
[root@ ~]# fallocate -l1MB /rhev/data-center/mnt/glusterSD/rhs-client10.lab.eng.blr.redhat.com\:vmstore/file1
fallocate: /rhev/data-center/mnt/glusterSD/rhs-client10.lab.eng.blr.redhat.com:vmstore/sas1: fallocate failed: Transport endpoint is not connected

I see the following error message in fuse mount logs

"[2015-09-08 16:57:29.796276] I [shard.c:3745:shard_fallocate] 0-vmstore-shard: fallocate called on 10292366-317e-406a-b45f-a49cec061c46. FOP not implemented. Failing with ENOTCONN
[2015-09-08 16:57:29.796311] W [fuse-bridge.c:1271:fuse_err_cbk] 0-glusterfs-fuse: 1012095: FALLOCATE() ERR => -1 (Transport endpoint is not connected)"

Comment 2 Vijay Bellur 2016-01-08 11:00:15 UTC
REVIEW: http://review.gluster.org/13196 (features/shard: Implement fallocate FOP) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 3 Vijay Bellur 2016-01-08 11:29:31 UTC
REVIEW: http://review.gluster.org/13196 (features/shard: Implement fallocate FOP.) posted (#2) for review on master by Krutika Dhananjay (kdhananj)

Comment 4 Vijay Bellur 2016-01-08 11:29:34 UTC
REVIEW: http://review.gluster.org/13198 (features/shard: Implement zerofill FOP) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 5 Vijay Bellur 2016-01-13 13:03:15 UTC
REVIEW: http://review.gluster.org/13196 (features/shard: Implement fallocate FOP) posted (#3) for review on master by Krutika Dhananjay (kdhananj)

Comment 6 Vijay Bellur 2016-01-13 13:03:18 UTC
REVIEW: http://review.gluster.org/13234 (features/shard: Implement zerofill FOP) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 7 Vijay Bellur 2016-01-13 13:03:22 UTC
REVIEW: http://review.gluster.org/13235 (features/shard: Implement discard FOP) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 8 Vijay Bellur 2016-01-18 11:10:24 UTC
REVIEW: http://review.gluster.org/13196 (features/shard: Implement fallocate FOP) posted (#4) for review on master by Krutika Dhananjay (kdhananj)

Comment 9 Vijay Bellur 2016-01-18 11:47:44 UTC
REVIEW: http://review.gluster.org/13196 (features/shard: Implement fallocate FOP) posted (#5) for review on master by Krutika Dhananjay (kdhananj)

Comment 10 Vijay Bellur 2016-01-19 00:18:18 UTC
COMMIT: http://review.gluster.org/13196 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit c535059299785f7d050482c257f10389c218048b
Author: Krutika Dhananjay <kdhananj>
Date:   Thu Oct 29 17:04:38 2015 +0530

    features/shard: Implement fallocate FOP
    
    Change-Id: I6f07074e94b115f6c6c2c59a8a1b58ba44b1c12a
    BUG: 1261841
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/13196
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Pranith Kumar Karampuri <pkarampu>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 11 Vijay Bellur 2016-01-19 09:34:50 UTC
REVIEW: http://review.gluster.org/13234 (features/shard: Implement zerofill FOP) posted (#2) for review on master by Krutika Dhananjay (kdhananj)

Comment 12 Vijay Bellur 2016-01-23 06:02:35 UTC
COMMIT: http://review.gluster.org/13234 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit e67712c06b64fb659824b3f79164f2789693acee
Author: Krutika Dhananjay <kdhananj>
Date:   Wed Jan 13 16:19:15 2016 +0530

    features/shard: Implement zerofill FOP
    
    Change-Id: Iabb89a502cc560edd7fe3755623c74a2ccb853d5
    BUG: 1261841
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/13234
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Pranith Kumar Karampuri <pkarampu>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 13 Vijay Bellur 2016-02-09 11:21:43 UTC
REVIEW: http://review.gluster.org/13405 (tests, shard: fallocate tests refactor) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 14 Vijay Bellur 2016-02-09 14:18:28 UTC
REVIEW: http://review.gluster.org/13405 (tests, shard: fallocate tests refactor) posted (#2) for review on master by Krutika Dhananjay (kdhananj)

Comment 15 Vijay Bellur 2016-02-25 13:03:43 UTC
REVIEW: http://review.gluster.org/13405 (tests, shard: fallocate tests refactor) posted (#3) for review on master by Krutika Dhananjay (kdhananj)

Comment 16 Vijay Bellur 2016-02-25 13:16:28 UTC
REVIEW: http://review.gluster.org/13523 (features/shard: Return ENOTSUP for unsupported fallocate flags) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 17 Vijay Bellur 2016-02-29 09:24:07 UTC
REVIEW: http://review.gluster.org/13405 (tests, shard: fallocate tests refactor) posted (#4) for review on master by Krutika Dhananjay (kdhananj)

Comment 18 Vijay Bellur 2016-03-02 06:46:12 UTC
REVIEW: http://review.gluster.org/13405 (tests, shard: fallocate tests refactor) posted (#5) for review on master by Krutika Dhananjay (kdhananj)

Comment 19 Vijay Bellur 2016-03-03 00:59:59 UTC
REVIEW: http://review.gluster.org/13523 (features/shard: Return ENOTSUP for unsupported fallocate flags) posted (#2) for review on master by Krutika Dhananjay (kdhananj)

Comment 20 Vijay Bellur 2016-03-03 08:23:17 UTC
REVIEW: http://review.gluster.org/13405 (tests, shard: fallocate tests refactor) posted (#6) for review on master by Krutika Dhananjay (kdhananj)

Comment 21 Vijay Bellur 2016-03-04 08:15:40 UTC
REVIEW: http://review.gluster.org/13405 (tests, shard: fallocate tests refactor) posted (#7) for review on master by Krutika Dhananjay (kdhananj)

Comment 22 Vijay Bellur 2016-03-04 08:17:09 UTC
REVIEW: http://review.gluster.org/13523 (features/shard: Return ENOTSUP for unsupported fallocate flags) posted (#3) for review on master by Krutika Dhananjay (kdhananj)

Comment 23 Vijay Bellur 2016-03-04 12:24:18 UTC
REVIEW: http://review.gluster.org/13523 (features/shard: Return ENOTSUP for unsupported fallocate flags) posted (#4) for review on master by Krutika Dhananjay (kdhananj)

Comment 24 Vijay Bellur 2016-03-04 12:46:36 UTC
REVIEW: http://review.gluster.org/13405 (tests, shard: fallocate tests refactor) posted (#8) for review on master by Krutika Dhananjay (kdhananj)

Comment 25 Vijay Bellur 2016-03-07 04:19:13 UTC
REVIEW: http://review.gluster.org/13523 (features/shard: Return ENOTSUP for unsupported fallocate flags) posted (#5) for review on master by Krutika Dhananjay (kdhananj)

Comment 26 Vijay Bellur 2016-03-07 11:29:30 UTC
REVIEW: http://review.gluster.org/13405 (tests, shard: fallocate tests refactor) posted (#9) for review on master by Krutika Dhananjay (kdhananj)

Comment 27 Vijay Bellur 2016-03-08 07:23:57 UTC
REVIEW: http://review.gluster.org/13405 (tests, shard: fallocate tests refactor) posted (#10) for review on master by Krutika Dhananjay (kdhananj)

Comment 28 Vijay Bellur 2016-03-08 11:25:08 UTC
REVIEW: http://review.gluster.org/13405 (tests, shard: fallocate tests refactor) posted (#11) for review on master by Krutika Dhananjay (kdhananj)

Comment 29 Vijay Bellur 2016-03-08 15:19:55 UTC
REVIEW: http://review.gluster.org/13523 (features/shard: Return ENOTSUP for unsupported fallocate flags) posted (#6) for review on master by Krutika Dhananjay (kdhananj)

Comment 30 Vijay Bellur 2016-03-09 02:42:30 UTC
COMMIT: http://review.gluster.org/13523 committed in master by Vijay Bellur (vbellur) 
------
commit c00722ff9d83d131e624f5499da05160d184cfba
Author: Krutika Dhananjay <kdhananj>
Date:   Thu Feb 25 18:27:09 2016 +0530

    features/shard: Return ENOTSUP for unsupported fallocate flags
    
    Basis: http://lists.gnu.org/archive/html/qemu-devel/2016-02/msg05101.html
    
    Change-Id: I5bf80b6e8caed3d7f136fc57e16abfb28869e009
    BUG: 1261841
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/13523
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Reviewed-by: Ravishankar N <ravishankar>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 31 Vijay Bellur 2016-03-09 07:14:07 UTC
REVIEW: http://review.gluster.org/13405 (tests, shard: fallocate tests refactor) posted (#12) for review on master by Krutika Dhananjay (kdhananj)

Comment 32 Vijay Bellur 2016-03-09 08:49:50 UTC
REVIEW: http://review.gluster.org/13405 (tests, shard: fallocate tests refactor) posted (#13) for review on master by Krutika Dhananjay (kdhananj)

Comment 33 Vijay Bellur 2016-03-09 13:16:44 UTC
REVIEW: http://review.gluster.org/13405 (tests, shard: fallocate tests refactor) posted (#14) for review on master by Krutika Dhananjay (kdhananj)

Comment 34 Vijay Bellur 2016-03-09 13:16:47 UTC
REVIEW: http://review.gluster.org/13657 (features/shard: Implement discard fop) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 35 Vijay Bellur 2016-03-10 03:04:09 UTC
REVIEW: http://review.gluster.org/13405 (tests, shard: fallocate tests refactor) posted (#15) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 36 Vijay Bellur 2016-03-10 06:53:18 UTC
REVIEW: http://review.gluster.org/13405 (tests, shard: fallocate tests refactor) posted (#16) for review on master by Krutika Dhananjay (kdhananj)

Comment 37 Vijay Bellur 2016-03-10 11:17:02 UTC
COMMIT: http://review.gluster.org/13405 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 6df883cef3e69b37a192aae9e979f95b32f8ad41
Author: Krutika Dhananjay <kdhananj>
Date:   Tue Feb 9 16:40:36 2016 +0530

    tests, shard: fallocate tests refactor
    
    Change-Id: I3f275185f4dcb1939e8074851c8f140c5e40b28d
    BUG: 1261841
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/13405
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Reviewed-by: Ravishankar N <ravishankar>
    CentOS-regression: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>

Comment 38 Vijay Bellur 2016-03-10 11:17:09 UTC
REVIEW: http://review.gluster.org/13657 (features/shard: Implement discard fop) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 39 Vijay Bellur 2016-03-11 10:26:46 UTC
REVIEW: http://review.gluster.org/13657 (features/shard: Implement discard fop) posted (#3) for review on master by Krutika Dhananjay (kdhananj)

Comment 40 Vijay Bellur 2016-03-11 19:10:35 UTC
COMMIT: http://review.gluster.org/13657 committed in master by Jeff Darcy (jdarcy) 
------
commit 0e048b309b64e574039fc1ebedb971791d43b5e1
Author: Krutika Dhananjay <kdhananj>
Date:   Tue Mar 8 15:44:04 2016 +0530

    features/shard: Implement discard fop
    
    Change-Id: Ia5bd8d36b21a586df6556fbec3474892d5871229
    BUG: 1261841
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/13657
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Pranith Kumar Karampuri <pkarampu>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 41 Mike McCune 2016-03-28 22:51:39 UTC
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 42 Niels de Vos 2016-06-16 13:36:20 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user