Bug 1261871

Summary:	Review Request: perl-HTML-HTML5-Entities - Drop-in replacement for HTML::Entities with HTML5 support
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-HTML-HTML5-Entities-0.004-1.fc24	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-09-11 06:30:18 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1261999

Description Petr Pisar 2015-09-10 11:00:51 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-HTML-HTML5-Entities/perl-HTML-HTML5-Entities.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-HTML-HTML5-Entities/perl-HTML-HTML5-Entities-0.004-1.fc24.src.rpm
Description:
This is a drop-in replacement for HTML::Entities Perl module. This replacement
provides the character entities defined in HTML5.

Fedora Account System Username: ppisar

Comment 1 Petr Šabata 2015-09-10 12:16:42 UTC

I believe the package is mostly fine.  Approving.


Just a few notes:

* `Creative Commons Attribution-ShareAlike', version 3.0, approved by Fedora as `CC-BY-SA', appears to be exactly the same, word to word, as this project's `Creative Commons Attribution ShareAlike 2.0 UK: England & Wales'.  I think using the tag is okay.  I'm just mentioning it so you're aware.

* The module author mentions the following copyright for the entity tables:

 Copyright (c) 2004-2007 by Apple Computer Inc, Mozilla Foundation,
 and Opera Software ASA.

 Copyright (c) 2007-2011 by Wakaba <w.cx>.

 Copyright (c) 2009-2012 by Toby Inkster <tobyink>.

I'm not sure whether it really applies in this case; it probably doesn't need to be mentioned in the package's License tag.  However, you could still add `Copyright only' to you list of licenses and ask legal@ whether it has to be there or not...

Comment 2 Petr Pisar 2015-09-10 14:58:27 UTC

New Package SCM Request
=======================
Package Name: perl-HTML-HTML5-Entities
Short Description: Drop-in replacement for HTML::Entities with HTML5 support
Upstream URL: http://search.cpan.org/dist/HTML-HTML5-Entities/
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2015-09-10 19:53:15 UTC

Git done (by process-git-requests).

Comment 4 Petr Pisar 2015-09-11 06:30:18 UTC

Thank you for the review and the repository.