Bug 1261999

Summary: Review Request: perl-Web-Paste-Simple - Simple PSGI-based pastebin-like web site
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Web-Paste-Simple-0.002-1.fc24 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-09-11 11:27:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1261871    
Bug Blocks:    

Description Petr Pisar 2015-09-10 14:55:26 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Web-Paste-Simple/perl-Web-Paste-Simple.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Web-Paste-Simple/perl-Web-Paste-Simple-0.002-1.fc24.src.rpm
Description:
Web::Paste::Simple is a lightweight PSGI application for operating
a pastebin-like web site. It provides syntax highlighting via the CodeMirror
JavaScript library. It should be fast enough for deployment via CGI.

Fedora Account System Username: ppisar

Comment 1 Petr Pisar 2015-09-11 07:06:18 UTC
Indeed immediate fedora‑review+?

Comment 2 Jitka Plesnikova 2015-09-11 08:36:55 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Web-Paste-Simple-0.002-1.fc24.noarch.rpm | sort | uniq -c
      1 perl >= 1:5.010
      1 perl(:MODULE_COMPAT_5.22.0)
      1 perl(Carp)
      1 perl(Data::UUID)
      1 perl(HTML::HTML5::Entities)
      1 perl(JSON)
      1 perl(Moo) >= 1.000000
      1 perl(MooX::Types::MooseLike::Base)
      1 perl(Path::Class::Dir)
      1 perl(Path::Class::File)
      1 perl(Plack::Request)
      1 perl(Plack::Response)
      1 perl(Text::Template)
      1 perl(aliased)
      1 perl(constant)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
$ rpm -qp --requires perl-Web-Paste-Simple-server-0.002-1.fc24.noarch.rpm | sort | uniq -c
      4 /bin/sh
      1 /usr/bin/plackup
      1 perl-Web-Paste-Simple = 0.002-1.fc24
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 shadow-utils
      4 systemd
Binary requires are Ok.

$ rpm -qp --provides perl-Web-Paste-Simple-0.002-1.fc24.noarch.rpm | sort | uniq -c
      1 perl(Web::Paste::Simple) = 0.002
      1 perl-Web-Paste-Simple = 0.002-1.fc24
$ rpm -qp --provides perl-Web-Paste-Simple-server-0.002-1.fc24.noarch.rpm | sort | uniq -c
      1 perl-Web-Paste-Simple-server = 0.002-1.fc24

Binary provides are Ok.

$ rpmlint ./perl-Web-Paste-Simple*
perl-Web-Paste-Simple.noarch: W: spelling-error Summary(en_US) pastebin -> paste bin, paste-bin, pastiness
perl-Web-Paste-Simple.noarch: W: spelling-error %description -l en_US pastebin -> paste bin, paste-bin, pastiness
perl-Web-Paste-Simple.noarch: W: invalid-license Artistic
perl-Web-Paste-Simple.src: W: spelling-error Summary(en_US) pastebin -> paste bin, paste-bin, pastiness
perl-Web-Paste-Simple.src: W: spelling-error %description -l en_US pastebin -> paste bin, paste-bin, pastiness
perl-Web-Paste-Simple.src: W: invalid-license Artistic
perl-Web-Paste-Simple-server.noarch: W: spelling-error Summary(en_US) pastebin -> paste bin, paste-bin, pastiness
perl-Web-Paste-Simple-server.noarch: W: no-documentation
perl-Web-Paste-Simple-server.noarch: W: non-standard-uid /var/lib/webpastesimple webpastesimple
perl-Web-Paste-Simple-server.noarch: W: non-standard-gid /var/lib/webpastesimple webpastesimple
perl-Web-Paste-Simple-server.noarch: E: non-standard-dir-perm /var/lib/webpastesimple 750
perl-Web-Paste-Simple-server.noarch: W: no-manual-page-for-binary web-paste-simple.psgi
3 packages and 1 specfiles checked; 1 errors, 11 warnings.

Rpmlint is ok


The package looks good. APPROVED.

Comment 3 Petr Pisar 2015-09-11 09:07:49 UTC
New Package SCM Request
=======================
Package Name: perl-Web-Paste-Simple
Short Description: Simple PSGI-based pastebin-like web site
Upstream URL: http://search.cpan.org/dist/Web-Paste-Simple/
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2015-09-11 11:17:00 UTC
Git done (by process-git-requests).

Comment 5 Petr Pisar 2015-09-11 11:27:34 UTC
Thank you for the review and the repository.