Bug 1262432

Summary:	DataIOEditor allows names with illegal characters
Product:	[Retired] JBoss BPMS Platform 6	Reporter:	Jeremy Lindop <jlindop>
Component:	jBPM Designer	Assignee:	Tihomir Surdilovic <tsurdilo>
Status:	CLOSED EOL	QA Contact:	Jozef Marko <jomarko>
Severity:	unspecified	Docs Contact:
Priority:	high
Version:	6.2.0	CC:	jomarko, kverlaen
Target Milestone:	ER5
Target Release:	6.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-03-27 19:39:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jeremy Lindop 2015-09-11 16:07:50 UTC

Description of problem:
DataIOEditor does not validate characters in datainput / dataoutput names

Version-Release number of selected component (if applicable):
bpms-6.3.0.CR2

Steps to Reproduce:
1. Create a new BP and add a User Activity
2. Edit the assignments property
3. Create a DataInput with name, e.g. "ab#$%def"

Names with illegal characters should not be allowed.

The old Assignments editor used the Javascript regular expression to validate names:
/^[a-z0-9\-\.\_]*$/i

Comment 1 Jeremy Lindop 2015-09-11 16:09:17 UTC

See also
https://bugzilla.redhat.com/show_bug.cgi?id=1256400

Comment 3 Jeremy Lindop 2015-10-21 16:33:45 UTC

Fixed by making the DataInput and DataOutput names be validated as they are typed. They are also validated when the user moves away from the TextBox - this ensures that copy-pasted values are validated.

Names of DataInputs/Outputs can contain only a-z,A-Z,0-9,-_.  This is the same set of characters used in the old DataInput / DataOutput dialog.

6.3.x
https://github.com/droolsjbpm/jbpm-designer/commit/760a0246fc2beaf92d1ce30c21be90cb27995f4e

master
https://github.com/droolsjbpm/jbpm-designer/commit/ed3a6394e2d0d7c387b6fb130c273fcbb3d408be

Comment 4 Jozef Marko 2015-11-03 14:16:55 UTC

Impossible to type white spaces or other special characters like #,@,%,$ as name for data assignment.

Verified on 6.2.0.ER5