Bug 1262872
Summary: | Review Request: perl-TeX-Encode - Encoding to LaTeX escapes | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> |
Component: | Package Review | Assignee: | Jitka Plesnikova <jplesnik> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | jplesnik, package-review |
Target Milestone: | --- | Flags: | jplesnik:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-10-05 18:15:39 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Tom "spot" Callaway
2015-09-14 13:52:24 UTC
Summary is ok License is ok Description is ok URL is ok All tests passed FIX: Source0 should contains %{version} instead of explicit version 1.3 Source0: http://search.cpan.org/CPAN/authors/id/T/TI/TIMBRODY/TeX-Encode-%{version}.tar.gz TODO: Please add Group tag Group: Development/Libraries TODO: Please replace %{__perl} by 'perl' FIX: Please add following build-requires - coreutils - perl-TeX-Encode.spec:35 - findutils - perl-TeX-Encode.spec:35 - make - perl-TeX-Encode.spec:31 - perl - perl-TeX-Encode.spec:30 - perl(Carp) - lib/TeX/Encode.pm:9 - perl(Encode) - t/01ltgt.t:9 - perl(strict) - lib/TeX/Encode.pm:4 - perl(vars) - lib/TeX/Encode/charmap.pm:13 FIX: Please replace PERL_INSTALL_ROOT by DESTDIR TODO: The following line could be remove, it is done by rpm find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';' $ rpm -qp --requires perl-TeX-Encode-1.3-1.fc24.noarch.rpm | sort | uniq -c 1 perl >= 0:5.008 1 perl(:MODULE_COMPAT_5.22.0) 1 perl(Carp) 1 perl(Encode::Encoding) 1 perl(TeX::Encode) 1 perl(TeX::Encode::BibTeX) 1 perl(TeX::Encode::charmap) 1 perl(strict) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -qp --provides perl-TeX-Encode-1.3-1.fc24.noarch.rpm | sort | uniq -c 1 perl(TeX::Encode) = 1.3 1 perl(TeX::Encode::BibTeX) = 1.2 1 perl(TeX::Encode::charmap) 1 perl-TeX-Encode = 1.3-1.fc24 Binary provides are Ok. $ rpmlint ./perl-TeX-Encode* perl-TeX-Encode.src: W: spelling-error %description -l en_US LaTeX -> Lat Ex, Late X, Latex perl-TeX-Encode.src: W: spelling-error %description -l en_US undef -> unfed, under, funded perl-TeX-Encode.noarch: W: spelling-error %description -l en_US LaTeX -> Lat Ex, Late X, Latex perl-TeX-Encode.noarch: W: spelling-error %description -l en_US undef -> unfed, under, funded 2 packages and 1 specfiles checked; 0 errors, 4 warnings. Rpmlint is ok Please correct all 'FIX' issues and consider fixing 'TODO' item The package is not approved. Please provide new spec file when you fix it. All changes applied, though the Group tag is unnecessary and some of the build-requires are safe to assume. New Spec URL: https://spot.fedorapeople.org/perl-TeX-Encode.spec New SRPM URL: https://spot.fedorapeople.org/perl-TeX-Encode-1.3-2.fc23.src.rpm -Source0: http://search.cpan.org/CPAN/authors/id/T/TI/TIMBRODY/TeX-Encode-1.3.tar.gz +Source0: http://search.cpan.org/CPAN/authors/id/T/TI/TIMBRODY/TeX-Encode-%{version}.tar.gz +Group: Development/Libraries > FIX: Source0 should contains %{version} instead of explicit version 1.3 > Source0: > http://search.cpan.org/CPAN/authors/id/T/TI/TIMBRODY/TeX-Encode-%{version}. > tar.gz Fixed > TODO: Please add Group tag > Group: Development/Libraries Fixed > TODO: Please replace %{__perl} by 'perl' %build -%{__perl} Makefile.PL INSTALLDIRS=vendor +perl Makefile.PL INSTALLDIRS=vendor make %{?_smp_mflags} Fixed. > FIX: Please add following build-requires > - coreutils - perl-TeX-Encode.spec:35 > - findutils - perl-TeX-Encode.spec:35 > - make - perl-TeX-Encode.spec:31 > - perl - perl-TeX-Encode.spec:30 > - perl(Carp) - lib/TeX/Encode.pm:9 > - perl(Encode) - t/01ltgt.t:9 > - perl(strict) - lib/TeX/Encode.pm:4 > - perl(vars) - lib/TeX/Encode/charmap.pm:13 BuildArch: noarch +BuildRequires: coreutils, findutils, make, perl +BuildRequires: perl(Carp), perl(Encode), perl(strict), perl(vars) BuildRequires: perl(ExtUtils::MakeMaker) Fixed. > FIX: Please replace PERL_INSTALL_ROOT by DESTDIR -make pure_install PERL_INSTALL_ROOT=%{buildroot} +make pure_install DESTDIR=%{buildroot} Fixed > > TODO: The following line could be remove, it is done by rpm > find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';' find %{buildroot} -type f -name .packlist -exec rm -f {} ';' -find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';' Fixed The package approved. New Package SCM Request ======================= Package Name: perl-TeX-Encode Short Description: Encoding to LaTeX escapes Upstream URL: http://search.cpan.org/dist/TeX-Encode/ Owners: spot Branches: f21 f22 f23 InitialCC: perl-sig Git done (by process-git-requests). perl-TeX-Encode-1.3-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15938 perl-TeX-Encode-1.3-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15939 perl-TeX-Encode-1.3-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update perl-TeX-Encode'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15938 perl-TeX-Encode-1.3-2.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update perl-TeX-Encode'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15937 perl-TeX-Encode-1.3-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update perl-TeX-Encode'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15939 perl-TeX-Encode-1.3-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. perl-TeX-Encode-1.3-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. perl-TeX-Encode-1.3-2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. |