Bug 1262890

Summary: RFE: ipmitool should return unsupported message string vs invalid command for unsupported features
Product: Red Hat Enterprise Linux 7 Reporter: Rachel Sibley <rasibley>
Component: ipmitoolAssignee: Vaclav Dolezal <vdolezal>
Status: CLOSED WONTFIX QA Contact: Rachel Sibley <rasibley>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.2Keywords: FutureFeature
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Feature: ipmitool Reason: change unsupported message string Result: current message string is misleading
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-12-12 13:45:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Rachel Sibley 2015-09-14 14:46:44 UTC
Description of problem:

Certain hardware does not support all ipmitool commands, for example on the HP Moonshot, you will get an error after executing certain unsupported commands.  The message string is misleading and is a catch-all for all unsupported features.  The invalid command result may mislead the customer to think they executed the command incorrectly vs executing on unsupported hardware.

Version-Release number of selected component (if applicable):
# rpm -q ipmitool
ipmitool-1.8.13-8.el7_1.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Execute an unsupported command, ie;
# ipmitool chassis identify
Set Chassis Identify failed: Invalid command

2.
3.

Actual results:
Set Chassis Identify failed: Invalid command

Expected results:
Set Chassis Identify failed: Unsupported command

Additional info:

Comment 3 Vaclav Dolezal 2019-12-12 13:45:48 UTC
Well, the string "Invalid command" comes directly from IPMI spec:

    Table 5-2, Completion Codes

    Code | Definition
    ------------------
    GENERIC COMPLETION CODES 00h, C0h-FFh
    ------------------
    00h  | Command Completed Normally.
    C0h  | Node Busy. Command could not be processed because command processing resources are temporarily unavailable.
>>> C1h  | Invalid Command. Used to indicate an unrecognized or unsupported command.
    C2h  | Command invalid for given LUN.
    ...

I don't think we should change it.

Anyway, as this is RFE for RHEL7, I'll close it.