Bug 1263438

Summary:	backport libvirt sanity checks
Product:	[Fedora] Fedora	Reporter:	Markus Stockhausen <mst>
Component:	libvirt	Assignee:	Libvirt Maintainers <libvirt-maint>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	22	CC:	agedosier, berrange, clalancette, crobinso, itamar, jforbes, laine, libvirt-maint, veillard, virt-maint
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libvirt-1.2.13.1-3.fc22	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-10-09 10:28:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Markus Stockhausen 2015-09-15 19:12:48 UTC

We just hit the error described in BZ1199036 on FC21. 

There are a lot of patches targeting block commit functionality for older libvirt releases. Nevertheless the 3 fixes described in the above BZ entry would allow for some fundamental sanity check.

It would be nice to see them backported for libvirt in FC21/FC22:

1) qemu: Disallow concurrent block jobs on a single disk
2) qemu: event: Don't fiddle with disk backing trees without a job
3) qemu: block-commit: Mark disk in block jobs only on successful command

Comment 1 Cole Robinson 2015-09-22 01:20:56 UTC

The patches don't apply cleanly to F21, and since they don't sound essential I'm not going to rock the boat there, figuring that F21 will be end of life before the end of the year. So I'll just backport them to f22

Comment 2 Markus Stockhausen 2015-09-22 06:44:05 UTC

Just saw that your FC22 build failed. I did not expect this helpful backport to be so tricky. Sorry for not checking the situation correctly in advance.

Nevertheless: Thanks a lot for your help in this matter.

Comment 3 Cole Robinson 2015-09-22 12:16:10 UTC

f22 build failed for some unrelated reason AFAICT, I'm looking into it

Comment 4 Fedora Update System 2015-09-23 21:23:04 UTC

libvirt-1.2.13.1-3.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update libvirt'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16421

Comment 5 Fedora Update System 2015-10-09 10:28:23 UTC

libvirt-1.2.13.1-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.