Bug 126368

Summary: crash if isodir contains bad link
Product: [Fedora] Fedora Reporter: frank van dijk <f.v.dijk>
Component: system-config-packagesAssignee: Jeremy Katz <katzj>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 2CC: mattdm
Target Milestone: ---   
Target Release: ---   
Hardware: i386   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-09-21 19:10:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description frank van dijk 2004-06-20 12:00:41 UTC
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040510

Description of problem:
I run fedora core 2, and have the cd images on an ext2 partition
containing an old linux installation. The partition is mounted on
/mnt/other, and the isos are located in /mnt/other/home/frank.

This directory happens to have a symlink
'.DCOPserver_localhost.localdomain' pointing to
'/home/frank/.DCOPserver_localhost.localdomain_:0', which does not
exist in this mount context.

When invoking 'system-config-packages --isodir=/mnt/other/home/frank'
it crashes with the traceback below.

As system-config-packages does not need to use the link, it should
ignore the fact that that it points to nothing.

A workaround is to create a subdir, moving the iso images into that
dir and using that dir for --isodir.
 	
Traceback (most recent call last):
  File "/usr/share/system-config-packages/MainWindow.py", line 160, in ?
    im = get_method(args)
  File "/usr/share/system-config-packages/config.py", line 57, in
get_method
    return method.LoopbackIsoInstallMethod(isodir)
  File "/usr/share/system-config-packages/method.py", line 342, in
__init__
    self.discImages = findIsoImages(tree)
  File "/usr/share/system-config-packages/method.py", line 859, in
findIsoImages
    diskutil.losetup(loopDev, what, readOnly = 1)
  File "/usr/lib/python2.3/site-packages/rhpl/diskutil.py", line 82,
in losetup
    targ = os.open(file, mode)
OSError: [Errno 2] No such file or directory:
'/mnt/other/home/frank/.DCOPserver_localhost.localdomain'


Version-Release number of selected component (if applicable):
1.2.12

How reproducible:
Always

Steps to Reproduce:
1. have the iso images in a dir together with a broken symlink
(perhaps the symlink must occur before the images in the dir-list)
2. run system-config-packages --isodir=<path/to/that/dir>

    

Additional info:

Comment 1 Matthew Miller 2005-04-26 15:10:40 UTC
Fedora Core 2 is now maintained by the Fedora Legacy project for
security updates only. If this problem is a security issue, please
reopen and reassign to the Fedora Legacy product. If it is not a
security issue and hasn't been resolved in the current FC3 updates or
in the FC4 test release, reopen and change the version to match.

Comment 2 Jeremy Katz 2005-09-21 19:10:52 UTC
Closing as fixed in a later release