Bug 1263785
| Summary: | Remove constants duplication in ovirt-engine-dwh and ovirt-engine-setup | ||
|---|---|---|---|
| Product: | [oVirt] ovirt-engine-dwh | Reporter: | Rafael Martins <rmartins> |
| Component: | Setup | Assignee: | Ido Rosenzwig <irosenzw> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Gonza <grafuls> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | 4.2.0 | CC: | bugs, didi, fabrice.bacchella, irosenzw, panormitis, pbrilla, sbonazzo, sradco, stirabos, ylavi |
| Target Milestone: | ovirt-4.2.0 | Keywords: | CodeChange, Reopened |
| Target Release: | 4.2.0 | Flags: | rule-engine:
ovirt-4.2+
rule-engine: planning_ack+ sbonazzo: devel_ack+ pstehlik: testing_ack+ |
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-12-20 10:44:26 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Integration | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1475130, 1631198 | ||
|
Description
Rafael Martins
2015-09-16 17:03:35 UTC
Proposing CodeChange, thus QE just sanity. Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release. Simone, IIRC you were for keeping these duplicated. What do you think? If everything depends on engine_common or if we have no side effects requiring it everywhere we can just move there. Update on this bug status? All patches have been merged. For some reason the status of several patches still 'NEW' but should be 'MERGED' The projects that changed are: - ovirt-engine - ovirt-dwh - ovirt-imageio For testing, please check if all the products are installed correctly and nothing is broken. *** Bug 1363824 has been marked as a duplicate of this bug. *** verified in rhevm-4.1.0.2-0.1.el7.noarch Reopening. I wasn't aware of [1], which reverts much of the changes for this bug. We are still affected by it in real life. E.g. patchset 28 of [2] failed, and to prevent the failure I pushed patchset 30, and also [3] for a "proper fix". The intent of current bug was that patches such as [3] would not be needed. Simone pushed [1] to fix dev-env without dwh. I understand the reasoning and can accept it as a temporary solution, but imo we need a better one on the long term - e.g. make dwh setup mandatory in dev-env, or somehow patch the engine to not fail if it's missing (no idea how much work this will require, the change between 28 and 30 in [2] wasn't hard). [1] https://gerrit.ovirt.org/65409 [2] https://gerrit.ovirt.org/70422 [3] https://gerrit.ovirt.org/71889 Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release. Didi, can you fix this? Now got a report that makes me think current bug is still not solved, bug 1465859. It seems like one of the patches removed [1] websocket-proxy's copy of ENGINE_FQDN, and that the engine's copy [2] wasn't changed to have its attributes. (The fact that they were different at the time is actually current bug). [1] https://gerrit.ovirt.org/#/c/65129/9/packaging/setup/ovirt_engine_setup/websocket_proxy/constants.py [2] https://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=blob;f=packaging/setup/ovirt_engine_setup/engine/constants.py;h=bdaee6092954995e86b523c2a8bbf2eee62ec6ff;hb=221c7edba2e615fdd8a7076d5f736d8bde4a6155#l682 Ido should be back in 1 week, Ido please have a look. Working on it. Movinf back to assigned as per comment #16 The additional issue that is mentioned on comment 14 is being tracked on [1]. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1465859 moving back to 'ON_QA' Verified with: ovirt-engine-4.2.0-0.0.master.20170907100709.git14accac.el7.centos.noarch ovirt-engine-setup-4.2.0-0.0.master.20170907100709.git14accac.el7.centos.noarch ovirt-engine-dwh-setup-4.2.1-0.0.master.20170906061716.el7.centos.noarch ovirt-imageio-common-1.1.0-1.el7.noarch This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017. Since the problem described in this bug report should be resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |