Bug 1263938
| Summary: | Review Request: perl-Etsy-StatsD - Object-Oriented Client for Etsy's StatsD Server | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jan Holcapek <holcapek> |
| Component: | Package Review | Assignee: | Petr Šabata <psabata> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | holcapek, package-review, psabata |
| Target Milestone: | --- | Flags: | psabata:
fedora-review?
holcapek: needinfo- |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | AwaitingSubmitter | ||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-03-07 16:40:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Jan Holcapek
2015-09-17 06:41:34 UTC
* The license is unclear -- while the README file and CPAN metadata claim the package is distributed under the `perl' license (generally understood as `GPL+ or Artistic'), the bundled license text is for `Artistic 2.0'. Please, ask upstream when they really meant.
* %description needs to end with a fullstop.
In your case, consider simple `%{summary}.'
* Feel free to use the more common DESTDIR rather than PERL_INSTALL_ROOT.
* Missing build deps ;)
- coreutils, called in spec, line 32
- findutils, ditto
- make, called in spec, lines 27, 30 and 37
- perl(IO::Socket::INET), lib/Etsy/StatsD.pm:35
* For obvious reasons, the automatic generators won't find that IO::Socket::INET dependency for you. You'll have to require it explicitly.
* Note: at the moment, the statsd package provides the `perl(Etsy::StatsD)' symbol. This is a bug. Reported as #1263969.
(In reply to Petr Šabata from comment #1) > * The license is unclear -- while the README file and CPAN metadata claim > the package is distributed under the `perl' license (generally understood as > `GPL+ or Artistic'), the bundled license text is for `Artistic 2.0'. > Please, ask upstream when they really meant. Waiting for their reply. > * %description needs to end with a fullstop. > In your case, consider simple `%{summary}.' > > * Feel free to use the more common DESTDIR rather than PERL_INSTALL_ROOT. > > * Missing build deps ;) > - coreutils, called in spec, line 32 > - findutils, ditto > - make, called in spec, lines 27, 30 and 37 > - perl(IO::Socket::INET), lib/Etsy/StatsD.pm:35 > > * For obvious reasons, the automatic generators won't find that > IO::Socket::INET dependency for you. You'll have to require it explicitly. All above fixed. > * Note: at the moment, the statsd package provides the `perl(Etsy::StatsD)' > symbol. This is a bug. Reported as #1263969. Good catch! Spec URL: https://raw.githubusercontent.com/holcapek/perl-Etsy-StatsD/master/perl-Etsy-StatsD.spec SRPM URL: https://github.com/holcapek/perl-Etsy-StatsD/raw/master/perl-Etsy-StatsD-1.001-2.fc21.src.rpm (In reply to Jan Holcapek from comment #2) > > * %description needs to end with a fullstop. > > In your case, consider simple `%{summary}.' > > > > * Feel free to use the more common DESTDIR rather than PERL_INSTALL_ROOT. > > > > * Missing build deps ;) > > - coreutils, called in spec, line 32 > > - findutils, ditto > > - make, called in spec, lines 27, 30 and 37 > > - perl(IO::Socket::INET), lib/Etsy/StatsD.pm:35 > > > > * For obvious reasons, the automatic generators won't find that > > IO::Socket::INET dependency for you. You'll have to require it explicitly. > > All above fixed. Ack. Any news? Ping. Closing as DEADREVIEW. |