Bug 1264136

Summary: Correct systemd file
Product: [Fedora] Fedora Reporter: James Hogarth <james.hogarth>
Component: sslhAssignee: James Hogarth <james.hogarth>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 22CC: extras-qa, james.hogarth, kai.reichert, peter.meier
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: sslh-1.17-3.fc22 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1260026 Environment:
Last Closed: 2015-10-03 21:16:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description James Hogarth 2015-09-17 15:10:21 UTC 
+++ This bug was initially created as a clone of Bug #1260026 +++

Description of problem:

This fixes in #1221320 introduced a bug in the systemd file.

Instead

ExecStart=/usr/sbin/sslh ${DAEMON_OPTS}

it should be read:

ExecStart=/usr/sbin/sslh $DAEMON_OPTS

You can't use brackets in systemd files.

The service won't start like that.

Version-Release number of selected component (if applicable):

# rpm -qi sslh                                                                                                       
Name        : sslh
Version     : 1.17
Release     : 2.el7



How reproducible:

Always

Steps to Reproduce:
1. install
2. configure
3. try to start and get

Sep  4 10:37:51 foo sslh: config:  /etc/sslh.cfg
Sep  4 10:37:51 foo systemd: sslh.service: main process exited, code=exited, status=4/NOPERMISSION


Actual results:

Service does not start

Expected results:

Service should start.

--- Additional comment from Kai Reichert on 2015-09-06 14:35:43 EDT ---

Yes, removing the braces around DAEMON_OPTS fixes the problem.
Please release a new package version.
Comment 1 Fedora Update System 2015-09-17 15:45:25 UTC 
sslh-1.17-3.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16111
Comment 2 Fedora Update System 2015-09-18 16:24:11 UTC 
sslh-1.17-3.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update sslh'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16111
Comment 3 Fedora Update System 2015-10-03 21:16:58 UTC 
sslh-1.17-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.