Bug 1264140

Summary:	Correct systemd file
Product:	[Fedora] Fedora	Reporter:	James Hogarth <james.hogarth>
Component:	sslh	Assignee:	James Hogarth <james.hogarth>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	extras-qa, james.hogarth, kai.reichert, peter.meier
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1260026	Environment:
Last Closed:	2015-09-17 16:05:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description James Hogarth 2015-09-17 15:18:00 UTC

+++ This bug was initially created as a clone of Bug #1260026 +++

Description of problem:

This fixes in #1221320 introduced a bug in the systemd file.

Instead

ExecStart=/usr/sbin/sslh ${DAEMON_OPTS}

it should be read:

ExecStart=/usr/sbin/sslh $DAEMON_OPTS

You can't use brackets in systemd files.

The service won't start like that.

Version-Release number of selected component (if applicable):

# rpm -qi sslh                                                                                                       
Name        : sslh
Version     : 1.17
Release     : 2.el7



How reproducible:

Always

Steps to Reproduce:
1. install
2. configure
3. try to start and get

Sep  4 10:37:51 foo sslh: config:  /etc/sslh.cfg
Sep  4 10:37:51 foo systemd: sslh.service: main process exited, code=exited, status=4/NOPERMISSION


Actual results:

Service does not start

Expected results:

Service should start.

--- Additional comment from Kai Reichert on 2015-09-06 14:35:43 EDT ---

Yes, removing the braces around DAEMON_OPTS fixes the problem.
Please release a new package version.

Comment 1 James Hogarth 2015-09-17 15:47:48 UTC

Hmm this is failing to build in rawhide... 

+ pod2man --section=8 --release=1.17 '--center= ' sslh.pod
/var/tmp/rpm-tmp.RI4Ofg: line 33: pod2man: command not found
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.RI4Ofg (%build)
    Bad exit status from /var/tmp/rpm-tmp.RI4Ofg (%build)
Child return code was: 1
EXCEPTION: Command failed. See logs for output.

Comment 2 James Hogarth 2015-09-17 16:05:03 UTC

Rawhide build has been fixed and the updated package with the correct systemd unit will be in the next compose.