Bug 1264149
Summary: | [RFE] ip link does not show query_rss state in vf link description | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 7 | Reporter: | Jaroslav Aster <jaster> |
Component: | iproute | Assignee: | Timothy Redaelli <tredaelli> |
Status: | CLOSED ERRATA | QA Contact: | Jaroslav Aster <jaster> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 7.3 | CC: | aloughla, atragler, kzhang, mleitner, psutter, rkhan, sukulkar |
Target Milestone: | rc | Keywords: | FutureFeature |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | iproute-3.10.0-75.el7 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-08-01 21:32:13 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Jaroslav Aster
2015-09-17 15:44:39 UTC
Patches sent upstream: https://www.mail-archive.com/netdev@vger.kernel.org/msg112491.html Upstream still has not accepted my patches - delaying for RHEL7.4 then. This took forever, but here are the patches to backport: commit ff9463e048a55d1262869ef6f6897c44c11fe094 Author: Phil Sutter <phil> Date: Tue Nov 8 22:29:11 2016 +0100 ipaddress: Simplify vf_info parsing Commit 7b8179c780a1a ("iproute2: Add new command to ip link to enable/disable VF spoof check") tried to add support for IFLA_VF_SPOOFCHK in a backwards-compatible manner, but aparently overdid it: parse_rtattr_nested() handles missing attributes perfectly fine in that it will leave the relevant field unassigned so calling code can just compare against NULL. There is no need to layback from the previous (IFLA_VF_TX_RATE) attribute to the next to check if IFLA_VF_SPOOFCHK is present or not. To the contrary, it establishes a potentially incorrect assumption of these two attributes directly following each other which may not be the case (although up to now, kernel aligns them this way). This patch cleans up the code to adhere to the common way of checking for attribute existence. It has been tested to return correct results regardless of whether the kernel exports IFLA_VF_SPOOFCHK or not. Signed-off-by: Phil Sutter <phil> Reviewed-by: Greg Rose <grose> commit 4fb4a10e120b16c292c215791decccc47dc14604 Author: Phil Sutter <phil> Date: Mon Nov 14 09:29:54 2016 +0100 ipaddress: Print IFLA_VF_QUERY_RSS_EN setting Signed-off-by: Phil Sutter <phil> Backported commits from upstream: commit ff9463e048a55d1262869ef6f6897c44c11fe094 Author: Phil Sutter <phil> Date: Tue Nov 8 22:29:11 2016 +0100 ipaddress: Simplify vf_info parsing Commit 7b8179c780a1a ("iproute2: Add new command to ip link to enable/disable VF spoof check") tried to add support for IFLA_VF_SPOOFCHK in a backwards-compatible manner, but aparently overdid it: parse_rtattr_nested() handles missing attributes perfectly fine in that it will leave the relevant field unassigned so calling code can just compare against NULL. There is no need to layback from the previous (IFLA_VF_TX_RATE) attribute to the next to check if IFLA_VF_SPOOFCHK is present or not. To the contrary, it establishes a potentially incorrect assumption of these two attributes directly following each other which may not be the case (although up to now, kernel aligns them this way). This patch cleans up the code to adhere to the common way of checking for attribute existence. It has been tested to return correct results regardless of whether the kernel exports IFLA_VF_SPOOFCHK or not. Signed-off-by: Phil Sutter <phil> Reviewed-by: Greg Rose <grose> commit 4fb4a10e120b16c292c215791decccc47dc14604 Author: Phil Sutter <phil> Date: Mon Nov 14 09:29:54 2016 +0100 ipaddress: Print IFLA_VF_QUERY_RSS_EN setting Signed-off-by: Phil Sutter <phil> commit fd4ca03935b13789a3e5f01eeda1395ed6cb3b2a Author: Julien Fortin <julien> Date: Fri Dec 16 17:36:05 2016 +0100 ip: vfinfo: remove code duplication for IFLA_VF_RSS_QUERY_EN Fixes: 4fb4a10e120b1 ("ipaddress: Print IFLA_VF_QUERY_RSS_EN setting”) Signed-off-by: Julien Fortin <julien> Acked-by: Phil Sutter <phil> Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:2171 |