Bug 1264164
Summary: | Review Request: python-rdoupdate - Manipulation and validation of YAML update files | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jakub Ruzicka <jruzicka> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | jruzicka, karlthered, package-review |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-08-12 15:21:07 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1246199 |
Description
Jakub Ruzicka
2015-09-17 17:00:11 UTC
%%prep %%build and %%install run ok with the spec but the mock build fails in the %%files section due to: cp: cannot stat 'LICENSE': No such file or directory The Manifest file do not include the license file: https://github.com/yac/rdoupdate/blob/master/MANIFEST.in Request upstream to include the License text in the pypi tarball, or patch the license text in %%prep. Upstream provides some test https://github.com/yac/rdoupdate/tree/master/tests So you must run the test in %%chech after build the package. You can use these new macros to build python libs: %build %py2_build %install %py2_install %check %{__python2} setup.py test Also you need to create a python2-%{name} subpackage and include a python provides macro: %package -n python2-%{name} Requires: xxxxx Recommends: xxxxx Summary: xxxxxx %{?python_provide:%python_provide python2-%{name}} Be sure to remove bundled egg.info in prep: %prep %setup -q rm -rf %{name}.egg.info Please check the current python spec template: https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file williamjmorenor's scratch build of python-rdoupdate-0.14-2.fc22.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11617947 * running tests is not possible as they require network access, so it's not a "must" * fixing MANIFEST.in is indeed required * drop the Group tag, it's unused. * I suggest a small change in description tag Manipulation and validation of RDO YAML update files * Using new macros is recommended but not mandatory For the record, Jakub is the upstream maintainer of rdoupdate. About new python guidelines, I admit they are more consistent but renaming packages to python2-xxx is creating unnecessary issues. I would have preferred that we let the python prefix die with python2 support and keep versioned pythonX for later major releases of Python. As this is not a general purpose module, it's only a dependency of rdopkg and used by a very limited set of people, I don't think it's worth enforcing this. Did make any progress in this packaging? Provide a python2-name, python3-name and using the python-provides macros is mandatory in Fedora Python Packaging I think we should close this ticket as rdoupdate is deprecated. rdoupdate is now deprecated. |