Bug 1264405

Summary:	Remove List<VdsNetworkInterface> nics from and pass only relevant information
Product:	[oVirt] ovirt-engine	Reporter:	Martin Mucha <mmucha>
Component:	BLL.Network	Assignee:	Martin Mucha <mmucha>
Status:	CLOSED NEXTRELEASE	QA Contact:
Severity:	low	Docs Contact:
Priority:	low
Version:	3.6.0	CC:	bugs, danken, mmucha, ylavi
Target Milestone:	ovirt-4.0.0-beta	Keywords:	CodeChange
Target Release:	---	Flags:	ylavi: ovirt-4.0.0? rule-engine: planning_ack+ rule-engine: devel_ack+ rule-engine: testing_ack?
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-05-23 07:25:18 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Network	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Martin Mucha 2015-09-18 11:52:03 UTC

Description of problem:
it's little bit misleading, since two collections of dbNics are getting passed around, while one of which is passed only to update nics with label.

from CR: https://gerrit.ovirt.org/#/c/45298/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java

The nics in the userConfiguredData are used only to update the labels. We can pass a list of nicNameToLabel instead.

Comment 1 Yaniv Lavi 2015-10-21 09:29:45 UTC

Please explain what the impact is and how urgent it is?

Comment 2 Martin Mucha 2015-10-22 12:18:21 UTC

no impact, absolutely not urgent.

I was asked to fill a bug for it so we do not forget about it. 
It's just an design issue; to certain place is send information in overly generic datastructure; any extra stuff is simply ignored. It just make code more fragile and harder to understand.

Comment 3 Martin Mucha 2016-01-08 08:02:00 UTC

should be done after other refactorings on UI in this area are done:
https://gerrit.ovirt.org/#/c/48544/

Comment 4 Sandro Bonazzola 2016-05-02 10:05:57 UTC

Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA.