Bug 1264482
| Summary: | Review Request: compat-nettle27 - Compat package with nettle libraries | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kalev Lember <klember> |
| Component: | Package Review | Assignee: | Pete Walter <walter.pete> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, walter.pete |
| Target Milestone: | --- | Flags: | walter.pete:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | compat-nettle27-2.7.1-1.fc23 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-09-19 13:08:25 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Kalev Lember
2015-09-18 14:56:17 UTC
For reference, here's the diff to the F22 nettle package: http://paste.fedoraproject.org/268945 I'd like to keep the diff to the original package down to the minimum in order to be able to easily share fixes when needed, so if possible please don't pick on the indentation and things like that that are also present in the original F22 package. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=11137312 Looks good to me, except for two small things I noticed: 1) this comment, # Explicitly conflict with older libvpx packages that ship libraries # with the same soname as this compat package should read "nettle" instead of "libvpx" here. 2) if you want you can remove "Group: Development/Libraries" line (both from the compat package and regular nettle) as nothing in Fedora uses group tags any more. Anyway, the two issues above are minor and don't block the review. Feel free to fix them before importing if you want. I am following https://fedoraproject.org/wiki/Package_Renaming_Process here and won't do a full review. - rpmlint output: compat-nettle27.src:10: W: macro-in-comment %{version} compat-nettle27.src:9: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 9) compat-nettle27.src: W: invalid-url Source0: nettle-2.7.1-hobbled.tar.gz compat-nettle27.x86_64: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 4 warnings. - licensing: OK, matches nettle - naming: OK - package installs correctly in Fedora 23 side by side with nettle - Obsoletes and Provides: not required in this case - Conflicts use looks right to me fedora-review has nothing interesting to say and I won't post its output here. Everything seems fine to me, so the package is: APPROVED Thanks for the quick review, Pete! New Package SCM Request ======================= Package Name: compat-nettle27 Short Description: Compat package with nettle libraries Upstream URL: http://www.lysator.liu.se/~nisse/nettle/ Owners: kalev Branches: f23 InitialCC: Git done (by process-git-requests). Package imported and built. |