Bug 1264541

Summary:	[GSS] (6.1.z) EventFactHandles are not deserialized correctly causing error "No enum constant org.drools.core.factmodel.traits.TraitTypeEnum.xxx"
Product:	[Retired] JBoss BPMS Platform 6	Reporter:	Gary Hu <ghu>
Component:	jBPM Core	Assignee:	Mario Fusco <mfusco>
Status:	CLOSED EOL	QA Contact:	Karel Suta <ksuta>
Severity:	high	Docs Contact:
Priority:	high
Version:	6.1.0	CC:	etirelli, ksuta, kverlaen, lpetrovi, mfusco, rsynek
Target Milestone:	CR1
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1264525	Environment:
Last Closed:	2020-03-27 19:02:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1264525
Bug Blocks:	1259378, 1259382

Description Gary Hu 2015-09-18 18:29:10 UTC

+++ This bug was initially created as a clone of Bug #1264525 +++

The following code causes errors "No enum constant org.drools.core.factmodel.traits.TraitTypeEnum.xxx" 

 XStream xstream = BatchExecutionHelper.newXStreamMarshaller();
 ...
 ExecutionResults results = (ExecutionResults) xstream.fromXML(responseXml);

The root cause is explained in the jira https://issues.jboss.org/browse/DROOLS-924
"EventFactHandle overrides DefaultFactHandle's toExternalForm(), but it is not happening the same for the createFromExternalFormat() method. Moreover no code takes care of the 1st argument (the format version) of the serialized format so when deserializing it always instance a DefaultFactHandle even when it was serialized an event."

--- Additional comment from Mario Fusco on 2015-09-18 12:47:14 EDT ---

Fixed by https://github.com/droolsjbpm/drools/commit/59d791076204d28ed370bf83b7f21e9864b0a701 and https://github.com/droolsjbpm/jbpm/commit/c6fd866c5

--- Additional comment from JBoss Product and Program Management on 2015-09-18 12:50:08 EDT ---

Since this issue was entered in Red Hat Bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.

Comment 3 Mario Fusco 2015-09-24 08:04:58 UTC

Cherry-picked to 6.2.x branch with https://github.com/droolsjbpm/drools/commit/e95a7bb58 and https://github.com/droolsjbpm/jbpm/commit/3fda3dd73

Comment 4 Mario Fusco 2015-09-24 15:16:33 UTC

Also this commit is necessary https://github.com/droolsjbpm/drools/commit/b066c0b69d3b762913a0c724a917dfd71a4340b6

Comment 5 Karel Suta 2015-10-12 13:29:07 UTC

Verified in 6.1.4