Bug 1264573

Summary: URL installs are busted with virt-manager/virt-install
Product: [Fedora] Fedora Reporter: Cole Robinson <crobinso>
Component: libvirtAssignee: Libvirt Maintainers <libvirt-maint>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 23CC: agedosier, berrange, clalancette, itamar, jforbes, laine, libvirt-maint, veillard, virt-maint
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 1.2.18.1-1.fc23 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-09-24 05:08:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Cole Robinson 2015-09-18 21:16:51 UTC
We need to backport this commit:

commit 269d39afe5c59ecb3d3d64dba52f8cfa8d63d197
Author: Guido Günther <agx>
Date:   Sun Aug 23 22:03:54 2015 +0200

    storage: only run safezero if allocation is > 0
    
    While a zero allocation in safezero should be fine it isn't when we use
    posix_fallocate which returns EINVAL on a zero allocation.
    
    While we could skip the zero allocation in safezero_posix_fallocate it's
    an optimization to do it for all allocations.
    
    This fixes vm installation via virtinst for me which otherwise aborts
    like:
    
       Starting install...
       Retrieving file linux...               | 5.9 MB     00:01 ...
       Retrieving file initrd.gz...           |  29 MB     00:07 ...
       ERROR    Couldn't create storage volume 'virtinst-linux.sBgds4': 'cannot fill file '/var/lib/libvirt/boot/virtinst-linux.sBgds4': Invalid argument'
    
    The error was introduced by e30297b0 as spotted by Chunyan Liu

Comment 1 Fedora Update System 2015-09-22 12:02:36 UTC
libvirt-1.2.18.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16416

Comment 2 Fedora Update System 2015-09-23 03:55:25 UTC
libvirt-1.2.18.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update libvirt'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16416

Comment 3 Fedora Update System 2015-09-24 05:08:02 UTC
libvirt-1.2.18.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.