Bug 1264653 (php-guzzlehttp-guzzle6)
| Summary: | Review Request: php-guzzlehttp-guzzle6 - PHP HTTP client | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shawn Iwinski <shawn> | ||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora, package-review | ||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2016-02-08 03:22:54 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1239252, 1302909 | ||||||||
| Attachments: |
|
||||||||
|
Description
Shawn Iwinski
2015-09-19 22:15:13 UTC
Of course... same questions that for php-aws-sdk2 (#1264654) Seems only used by php-aws-sdk. Sorry, "package" was the wrong term to use here. Many projects I have seen upstream have not updated to AWS API v3 or Guzzle v6 yet (I still find "new" projects using Guzzle v3!) so I would like to keep both of these package versions available while still being able to update the main RPM packages to their latest version. Version 6 instead of version 5. Spec URL: https://raw.githubusercontent.com/siwinski/rpms/ffc22fed958144d9aef034b3233b53e7bf352438/php-guzzlehttp-guzzle6/php-guzzlehttp-guzzle6.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-guzzlehttp-guzzle6-6.1.1-1.fc23.src.rpm remi's scratch build of php-guzzlehttp-guzzle6-6.1.1-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12096822 Created attachment 1103047 [details]
phpci.log
phpCompatInfo version 4.5.2 DB built Nov 25 2015 18:15:42 CET
static analyze results
Created attachment 1103048 [details]
review.txt
Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/php/GuzzleHttp6
Notice: I have absolutely no idea what is the best path for such "dual-version" libraries.
- does it make sense to have it in /usr/share/php (where we are trying to preserve a PSR-0 tree) ?
- could a separate tree be better ? (/usr/share/php-guzzlehttp-guzzle6/GuzzleHttp...)
- perhaps we should expose the autoloader path in some rpm macro
Really not a blocker, just my thoughts of the day... (/me should try to shutdown his brain...)
Just fix the trivial blocker, everything else is ok.
(In reply to Remi Collet from comment #7) > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/share/php/GuzzleHttp6 Updated Diff: https://github.com/siwinski/rpms/commit/d61ec0e212076f3029c41fe85e68d34fadfbeb05 Spec URL: https://raw.githubusercontent.com/siwinski/rpms/d61ec0e212076f3029c41fe85e68d34fadfbeb05/php-guzzlehttp-guzzle6/php-guzzlehttp-guzzle6.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-guzzlehttp-guzzle6-6.1.1-2.fc23.src.rpm [x]: Package must own all directories that it creates. === APPROVED === Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/php-guzzlehttp-guzzle6 THANKS for the review @Remi php-guzzlehttp-guzzle6-6.1.1-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f3f370291d php-guzzlehttp-guzzle6-6.1.1-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-7e0f762e8d php-guzzlehttp-guzzle6-6.1.1-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f3f370291d php-guzzlehttp-guzzle6-6.1.1-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f3f370291d php-guzzlehttp-guzzle6-6.1.1-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7e0f762e8d php-guzzlehttp-guzzle6-6.1.1-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f3f370291d php-guzzlehttp-guzzle6-6.1.1-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. php-guzzlehttp-guzzle6-6.1.1-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. |