Bug 1264687

Summary:	RFE: use libvirt virDomainRename
Product:	[Community] Virtualization Tools	Reporter:	Cole Robinson <crobinso>
Component:	virt-manager	Assignee:	Cole Robinson <crobinso>
Status:	CLOSED DEFERRED	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	berrange, crobinso, gscrivan, juzhou
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-06-15 17:24:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Cole Robinson 2015-09-20 18:18:12 UTC

Since libvirt 1.2.19 there's a virDomainRename API, we should look into using this instead of our hacked up undefine/redefine method which loses some state like managedsave, etc. Though as of this writing it doesn't look like the API handles moving snapshots, so it's still not a 100% solution.

API docs: https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainRename

Comment 1 Cole Robinson 2017-10-11 19:03:37 UTC

*** Bug 1496394 has been marked as a duplicate of this bug. ***

Comment 2 Cole Robinson 2019-06-15 17:24:25 UTC

If someone shows up on list with a patch for this I will consider it. But IMO the api doesn't add much over our current implementation, and having to support it will actually complicate code and testing since we will want to maintain the old code for non-qemu drivers. So I don't think this is worth explicitly tracking