Bug 1264703

Summary:	Review Request: syntastic - A vim plugins to check syntax for programming languages
Product:	[Fedora] Fedora	Reporter:	MERCIER Jonathan <bioinfornatics>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	bioinfornatics, package-review
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-10-10 20:28:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description MERCIER Jonathan 2015-09-20 22:35:46 UTC

New Package SCM Request
=======================
Package Name: syntastic
Short Description: syntastic
Upstream URL: https://github.com/scrooloose/syntastic
Owners: bioinfornatics
Branches: rawhide f23

Note: it was retired due to a broken dep and thus needs a re-review.
https://admin.fedoraproject.org/pkgdb/package/syntastic

Comment 1 MERCIER Jonathan 2015-09-20 22:39:12 UTC

SPEC: http://www.bioinfornatics.eu/packages/syntastic.spec
SRPMS: http://www.bioinfornatics.eu/packages/syntastic-3.6.0-1.fc22.src.rpm

Comment 2 Pierre-YvesChibon 2015-09-21 07:56:20 UTC

Again wrong component.
Again was retired too long ago (for broken deps) and needs a full new review: https://admin.fedoraproject.org/pkgdb/package/syntastic/

Comment 3 Raphael Groner 2016-03-28 19:20:11 UTC

Some general advice in prior:

a. Upstream has official releases. You should package the latest. Why do you 
   want to use a git snapshot?
   https://github.com/scrooloose/syntastic/releases
-Version:        3.6.0
-URL:            https://github.com/scrooloose/syntastic
-Source0:        %{name}-%{alphatag}.tar.xz
+Version:        3.7.0
+URL:            https://github.com/scrooloose/%{name}
+Source0:        %{url}/archive/%{version}.tar.gz#/%{name}-%{version}.tar.xz

b. Remove explicit (why?) BuildRequires:  glibc-common
c. You must use %license LICENCE

Please fix the above points, then I could do an official fedora-review.