Bug 1265164

Summary: oVirt Guest Agent Fails PEP8 lint (pep8 1.6.2)
Product: [oVirt] ovirt-guest-agent Reporter: Vinzenz Feenstra [evilissimo] <vfeenstr>
Component: GeneralAssignee: Vinzenz Feenstra [evilissimo] <vfeenstr>
Status: CLOSED CURRENTRELEASE QA Contact: Jiri Belka <jbelka>
Severity: medium Docs Contact:
Priority: unspecified    
Version: ---CC: bugs, gklein, lveyde, michal.skrivanek
Target Milestone: ovirt-3.6.0-rc3Keywords: CodeChange
Target Release: 1.0.11-2Flags: rule-engine: ovirt-3.6.0+
ylavi: planning_ack+
rule-engine: devel_ack+
pstehlik: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: virt
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-01-13 14:38:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Vinzenz Feenstra [evilissimo] 2015-09-22 09:24:12 UTC
Source: ovirt-guest-agent
Version: 1.0.10.2.dfsg-2
Severity: serious
Justification: fails to build from source
User: reproducible-builds.debian.org
Usertags: ftbfs
X-Debbugs-Cc: reproducible-builds.debian.org

Dear Maintainer,

ovirt-guest-agent fails to build from source in unstable/amd64 as the
PEP8 linting errors are considered fatal in the build system (There has
been a recent update of the pep8 package from 1.5.7 → 1.6.2)

  [..]
  make  check-local
  make[3]: Entering directory
  '/tmp/buildd/ovirt-guest-agent-1.0.10.2.dfsg'
  /usr/bin/pep8 --exclude="ovirt-guest-agent/setup.py" --filename
  '*.py,*.py.in' \
  	ovirt-guest-agent/CredServer.py
  	ovirt-guest-agent/GuestAgentLinux2.py
  	ovirt-guest-agent/GuestAgentWin32.py
  	ovirt-guest-agent/LockActiveSession.py
  	ovirt-guest-agent/OVirtAgentLogic.py
  	ovirt-guest-agent/OVirtGuestService.py
  	ovirt-guest-agent/VirtIoChannel.py ovirt-guest-agent/WinFile.py
  	ovirt-guest-agent/ovirt-guest-agent.py
  	ovirt-guest-agent/version.py tests/*.py
  ovirt-guest-agent/CredServer.py:39:1: E402 module level import not at
  top of file
  ovirt-guest-agent/GuestAgentWin32.py:37:19: E721 do not compare types,
  use 'isinstance()'
  ovirt-guest-agent/OVirtAgentLogic.py:35:1: E402 module level import
  not at top of file
  ovirt-guest-agent/OVirtAgentLogic.py:36:1: E402 module level import
  not at top of file
  ovirt-guest-agent/ovirt-guest-agent.py:35:1: E402 module level import
  not at top of file
  Makefile:902: recipe for target 'check-local' failed
  make[3]: *** [check-local] Error 1
  make[3]: Leaving directory
  '/tmp/buildd/ovirt-guest-agent-1.0.10.2.dfsg'
  Makefile:768: recipe for target 'check-am' failed
  make[2]: *** [check-am] Error 2
  make[2]: Leaving directory
  '/tmp/buildd/ovirt-guest-agent-1.0.10.2.dfsg'
  Makefile:480: recipe for target 'check-recursive' failed
  make[1]: *** [check-recursive] Error 1
  make[1]: Leaving directory
  '/tmp/buildd/ovirt-guest-agent-1.0.10.2.dfsg'
  dh_auto_test: make -j1 check returned exit code 2
  debian/rules:18: recipe for target 'build' failed
  make: *** [build] Error 2
  dpkg-buildpackage: error: debian/rules build gave error exit status 2

  [..]

The full build log is attached or can be viewed here:

    https://reproducible.debian.net/logs/unstable/amd64/ovirt-guest-agent_1.0.10.2.dfsg-2.build1.log.gz

Comment 1 Jiri Belka 2016-01-05 16:36:48 UTC
which WGT iso does include this guest agent version please?

Comment 2 Jiri Belka 2016-01-12 10:26:29 UTC
CodeChange and Debian...

Comment 3 Jiri Belka 2016-01-12 11:12:39 UTC
make  check-local
make[3]: Entering directory '/build/ovirt-guest-agent-1.0.11.2.dfsg'
/usr/bin/pep8 --exclude="ovirt-guest-agent/setup.py" --filename '*.py,*.py.in' \
        ovirt-guest-agent/CredServer.py ovirt-guest-agent/GuestAgentLinux2.py ovirt-guest-agent/GuestAgentWin32.py ovirt-guest-agent/LockActiveSession.py ovirt-guest-agent/OVirtAgentLogic.py ovirt-guest-agent/OVirtGuestService.py ovirt-guest-agent/VirtIoChannel.py ovirt-guest-agent/WinFile.py ovirt-guest-agent/ovirt-guest-agent.py ovirt-guest-agent/version.py tests/*.py
/bin/bash: line 1: git: command not found
make[3]: Leaving directory '/build/ovirt-guest-agent-1.0.11.2.dfsg'
make[2]: Leaving directory '/build/ovirt-guest-agent-1.0.11.2.dfsg'

Comment 4 Sandro Bonazzola 2016-01-13 14:38:33 UTC
oVirt 3.6.0 has been released, closing current release