Bug 1266805

Summary:	Review Request: springframework-social - Connect your applications with SaaS providers such as Facebook and Twitter
Product:	[Fedora] Fedora	Reporter:	gil cattaneo <puntogil>
Component:	Package Review	Assignee:	Tom "spot" Callaway <tcallawa>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, tcallawa
Target Milestone:	---	Flags:	tcallawa: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-11-22 02:24:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1266806

Description gil cattaneo 2015-09-28 01:44:57 UTC

Spec URL: https://gil.fedorapeople.org/springframework-social.spec
SRPM URL: https://gil.fedorapeople.org/springframework-social-1.0.3-1.fc22.src.rpm
Description:
The Spring Social project allows you to integrate the
APIs exposed by Software-as-a-Service (SaaS) providers
such as Facebook and Twitter into your applications.
It consists of a service provider 'connect' framework,
sign-in support, and strongly-typed Java API bindings
Fedora Account System Username: gil

Comment 1 Tom "spot" Callaway 2015-11-10 19:51:20 UTC

Good:

- rpmlint checks return nothing.
- package meets naming guidelines
- package meets packaging guidelines
- license (ASL 2.0) OK, text in %license, matches source
- spec file legible, in am. english
- source matches upstream (b219ac0fee6a3c35e8812d8ad5b13f1b700e0cf167414f54cf250fb29dc9d058)
- package compiles on f23 (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- javadoc ok
- nothing in %doc affects runtime
- no need for .desktop file 

As always, a very good package gil. Nice work.

Comment 2 gil cattaneo 2015-11-10 20:07:40 UTC

Thanks!

Request for new package:
https://admin.fedoraproject.org/pkgdb/package/requests/1460
https://admin.fedoraproject.org/pkgdb/package/requests/1461

Comment 3 Gwyn Ciesla 2015-11-11 14:15:08 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/springframework-social

Comment 4 Fedora Update System 2015-11-11 14:49:58 UTC

springframework-social-1.0.3-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-f3f521a103

Comment 5 Fedora Update System 2015-11-12 03:57:46 UTC

springframework-social-1.0.3-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update springframework-social'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-f3f521a103

Comment 6 Fedora Update System 2015-11-22 02:24:06 UTC

springframework-social-1.0.3-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.