Bug 1266806

Summary:	Review Request: springframework-social-twitter - Spring Social Twitter API binding and connect support
Product:	[Fedora] Fedora	Reporter:	gil cattaneo <puntogil>
Component:	Package Review	Assignee:	Tom "spot" Callaway <tcallawa>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, tcallawa
Target Milestone:	---	Flags:	tcallawa: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-11-22 02:23:58 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1266805
Bug Blocks:	1266804

Description gil cattaneo 2015-09-28 01:46:20 UTC

Spec URL: https://gil.fedorapeople.org/springframework-social-twitter.spec
SRPM URL: https://gil.fedorapeople.org/springframework-social-twitter-1.0.5-1.fc22.src.rpm
Description:
Spring Social Twitter is an extension of Spring Social that enables you to
connection your application with Twitter's REST API.
Fedora Account System Username: gil

Comment 1 Tom "spot" Callaway 2015-11-10 20:16:07 UTC

Bonus review!

Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (ASL 2.0) OK, text in %license, matches source
- spec file legible, in am. english
- source matches upstream (19aa299a36e66c4366e699a6c6bcb06e0b5459e7b8652f5d556fe5950fc0739a)
- package compiles on f23 (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- javadoc okay
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED

Comment 2 gil cattaneo 2015-11-10 20:32:37 UTC

Thanks!

Request for new package:
https://admin.fedoraproject.org/pkgdb/package/requests/1470
https://admin.fedoraproject.org/pkgdb/package/requests/1471

Comment 3 Gwyn Ciesla 2015-11-11 14:19:54 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/springframework-social-twitter

Comment 4 Fedora Update System 2015-11-11 15:40:22 UTC

springframework-social-twitter-1.0.5-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-272f1c6838

Comment 5 Fedora Update System 2015-11-12 03:57:40 UTC

springframework-social-twitter-1.0.5-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update springframework-social-twitter'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-272f1c6838

Comment 6 Fedora Update System 2015-11-22 02:23:56 UTC

springframework-social-twitter-1.0.5-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.