Bug 1268060

Summary:

s-m-gui register dialog should have a Close button. Again. Really.

Product:

Red Hat Enterprise Linux 7

Reporter:

Adrian Likins <alikins>

Component:

subscription-manager

Assignee:

candlepin-bugs

Status:

CLOSED ERRATA

QA Contact:

Sean Toner <stoner>

Severity:

medium

Docs Contact:

Priority:

medium

Version:

7.2

CC:

bcourt, crog, stoner, vrjain

Target Milestone:

Target Release:

---

Hardware:

Unspecified

OS:

Unspecified

Whiteboard:

Fixed In Version:

Doc Type:

Bug Fix

Doc Text:

Story Points:

---

Clone Of:

Environment:

Last Closed:

2015-11-19 11:51:10 UTC

Type:

Bug

Regression:

---

Mount Type:

---

Documentation:

---

CRM:

Verified Versions:

Category:

---

oVirt Team:

---

RHEL 7.3 requirements from Atomic Host:

Cloudforms Team:

---

Target Upstream Version:

Embargoed:

Attachments:

Description	Flags
register dialogs with a close button	none

Description Adrian Likins 2015-10-01 17:26:11 UTC

Description of problem:
There is no on screen way to close the registergui dialog in subscription-manager-gui now since 'back' replaced 'cancel' and the dialog type means no wm 'x' close button.

Version-Release number of selected component (if applicable):
subscription-manager-1.15.9-13

How reproducible:


Steps to Reproduce:
Open 'Register' or 'Auto Attach' dialog.
Try to close it.

Actual results:
No obvious way (esc/alt-f4/wm right click->close still work)

Expected results:
A cancel button. We all love cancel buttons.
We should add 5 or 6 of them.

Don't do that. Just one please.

Comment 1 Adrian Likins 2015-10-01 17:28:31 UTC

upstream pr at https://github.com/candlepin/subscription-manager/pull/1314

Comment 3 Barnaby Court 2015-10-02 15:18:20 UTC

Use a Close button instead of Cancel as we are closing the window and not reversing changes.

Comment 4 John Sefler 2015-10-06 15:20:23 UTC

Proposing as a blocker for rhel-7.2.0 to reinstate the Cancel/Close button that is already familiar to users of subscription-manager-gui from the prior rhel-7.1.0 release.

Comment 9 Sean Toner 2015-10-12 12:26:04 UTC

All the subdialogs of the registration process now have a Close button on the far left.  I tried registering a system and at each point clicked the Close button (even if there was a progress slider).  At each point the Close button would close out of the Register dialog.

The actual registration was not prevented from occurring however.  For example, after entering the username and password and clicking next, even though there is a progress slider while the system tries to register, if the user clicks Close at this point all it does is close the dialog.  The user will see that the system actually does register (though it will not auto-attach).

However, this more closely reflects the definition of close.  It does not cancel the registration process, nor does it bring the user back to a previous stage of the Registration process.

Attached are the various steps during registration where the Close button is visible.  The register-with-close-after-user-pw.png shows what the user will see if at some point after entering the username and password and hitting next, on the following dialog the Close button is clicked.  It shows that the system is actually registered.

Comment 10 Sean Toner 2015-10-12 12:28:14 UTC

Created attachment 1081991 [details]
register dialogs with a close button

Tested on 

[root@dhcp129-49 ~]# rpm -qa | grep subscription
subscription-manager-1.15.9-14.el7.x86_64
subscription-manager-gui-1.15.9-14.el7.x86_64
subscription-manager-initial-setup-addon-1.15.9-14.el7.x86_64

Comment 11 errata-xmlrpc 2015-11-19 11:51:10 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2122.html