Bug 1268287
| Summary: | user space tool shouldn'd end on traceback | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Tereza Cerna <tcerna> | ||||
| Component: | tuna | Assignee: | John Kacur <jkacur> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Jiri Kastner <jkastner> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 7.3 | CC: | bhu, jkacur, jkastner, jskarvad | ||||
| Target Milestone: | rc | ||||||
| Target Release: | 7.3 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: |
Tuna will now display a usage message if the user doesn't supply a value to the -c option.
|
Story Points: | --- | ||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2016-11-04 05:15:12 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1274397, 1282960, 1313485 | ||||||
| Attachments: |
|
||||||
$ tuna -c "" -P
Traceback (most recent call last):
File "/usr/bin/tuna", line 647, in <module>
main()
File "/usr/bin/tuna", line 490, in main
(op, a) = pick_op(a)
File "/usr/bin/tuna", line 405, in pick_op
if argument[0] in ('+', '-'):
IndexError: string index out of range
Tuna should verify the input and not traceback.
Created attachment 1162956 [details]
Display usage msg instead of traceback when arg to -c is missing or nonesense
I sent this patch upstream
Fixed in tuna-0.13-3.el7 and up Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHEA-2016-2392.html |
User space tool shouldn't end on traceback. # rpm -q tuna tuned tuna-0.11.1-10.el7.noarch tuned-2.5.1-4.el7.noarch # tuna -c -P Traceback (most recent call last): File "/usr/bin/tuna", line 656, in <module> main() File "/usr/bin/tuna", line 494, in main op_list = tuna.cpustring_to_list(a) File "/usr/lib/python2.7/site-packages/tuna/tuna.py", line 124, in cpustring_to_list ends = [ int(a, 0) for a in field.split("-") ] ValueError: invalid literal for int() with base 0: 'P' Second founded traceback: # tuned-adm profile realtime # tuned-adm verify Verification failed, current system settings differ from the preset profile. See tuned.log for details. You can mostly fix this by Tuned restart, e.g.: service tuned restart # cat /var/log/tuned/tuned.log ... 2015-10-02 13:15:50,510 INFO tuned.plugins.plugin_script: calling script '/usr/lib/tuned/realtime/script.sh' with argument 'verify' 2015-10-02 13:15:50,618 ERROR tuned.plugins.plugin_script: script '/usr/lib/tuned/realtime/script.sh' error: 1, 'Traceback (most recent call last): File "/usr/bin/tuna", line 656, in <module> main() File "/usr/bin/tuna", line 493, in main (op, a) = pick_op(a) File "/usr/bin/tuna", line 408, in pick_op if argument[0] in ('+', '-'): IndexError: string index out of range' 2015-10-02 13:15:50,619 ERROR tuned.plugins.plugin_script: verify: failed: [u'/usr/lib/tuned/realtime/script.sh'] ...